• Nick Bowler's avatar
    xfs: Fix x32 ioctls when cmd numbers differ from ia32. · a9d25bde
    Nick Bowler authored
    Several ioctl structs change size between native 32-bit (ia32) and x32
    applications, because x32 follows the native 64-bit (amd64) integer
    alignment rules and uses 64-bit time_t.  In these instances, the ioctl
    number changes so userspace simply gets -ENOTTY.  This scenario can be
    handled by simply adding more cases.
    
    Looking at the different ioctls implemented here:
    
    - All the ones marked 'No size or alignment issue on any arch' should
      presumably all be fine.
    
    - All the ones under BROKEN_X86_ALIGNMENT are different under integer
      alignment rules.  Since x32 matches amd64 here, we just need both
      sets of cases handled.
    
    - XFS_IOC_SWAPEXT has both integer alignment differences and time_t
      differences.  Since x32 matches amd64 here, we need to add a case
      which calls the native implementation.
    
    - The remaining ioctls have neither 64-bit integers nor time_t, so
      x32 matches ia32 here and no change is required at this level.  The
      bulkstat ioctl implementations have some pointer chasing which is
      handled separately.
    Signed-off-by: default avatarNick Bowler <nbowler@draconx.ca>
    Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    a9d25bde
xfs_ioctl32.c 18.7 KB