• Alexander van Heukelum's avatar
    x86: traps_xx: modify default_do_nmi · abd34807
    Alexander van Heukelum authored
     - local caching of smp_processor_id() in default_do_nmi()
     - v2: do not split default_do_nmi over two lines
    
    On Wed, Jul 02, 2008 at 08:12:20PM +0400, Cyrill Gorcunov wrote:
    > | -static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
    > | +static notrace __kprobes void
    > | +default_do_nmi(struct pt_regs *regs)
    > | [ ... ]
    > | -asmlinkage notrace  __kprobes void default_do_nmi(struct pt_regs *regs)
    > | +asmlinkage notrace __kprobes void
    > | +default_do_nmi(struct pt_regs *regs)
    >
    > Hi Alexander, good done, thanks! But why did you split default_do_nmi
    > definition by two lines? I think it would be better to keep them as it
    > was before, ie by a single line
    >
    > 	static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
    
    Thanks! Here is the replacement patch with default_do_nmi left on
    a single line.
    Signed-off-by: default avatarAlexander van Heukelum <heukelum@fastmail.fm>
    Acked-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    abd34807
traps_32.c 30.9 KB