• Jamal Hadi Salim's avatar
    net sched actions: fix GETing actions · aecc5cef
    Jamal Hadi Salim authored
    With the batch changes that translated transient actions into
    a temporary list lost in the translation was the fact that
    tcf_action_destroy() will eventually delete the action from
    the permanent location if the refcount is zero.
    
    Example of what broke:
    ...add a gact action to drop
    sudo $TC actions add action drop index 10
    ...now retrieve it, looks good
    sudo $TC actions get action gact index 10
    ...retrieve it again and find it is gone!
    sudo $TC actions get action gact index 10
    
    Fixes: 22dc13c8 ("net_sched: convert tcf_exts from list to pointer array"),
    Fixes: 824a7e88 ("net_sched: remove an unnecessary list_del()")
    Fixes: f07fed82 ("net_sched: remove the leftover cleanup_a()")
    Acked-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    aecc5cef
act_api.c 23.7 KB