• Josh Poimboeuf's avatar
    x86/entry/64: Fix paranoid_entry() frame pointer warning · b3ccefae
    Josh Poimboeuf authored
    With the following commit:
    
      f09d160992d1 ("x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros")
    
    ... one of my suggested improvements triggered a frame pointer warning:
    
      arch/x86/entry/entry_64.o: warning: objtool: paranoid_entry()+0x11: call without frame pointer save/setup
    
    The warning is correct for the build-time code, but it's actually not
    relevant at runtime because of paravirt patching.  The paravirt swapgs
    call gets replaced with either a SWAPGS instruction or NOPs at runtime.
    
    Go back to the previous behavior by removing the ELF function annotation
    for paranoid_entry() and adding an unwind hint, which effectively
    silences the warning.
    Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Dominik Brodowski <linux@dominikbrodowski.net>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: kbuild-all@01.org
    Cc: tipbuild@zytor.com
    Fixes: f09d160992d1 ("x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros")
    Link: http://lkml.kernel.org/r/20180212174503.5acbymg5z6p32snu@trebleSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    b3ccefae
entry_64.S 44.9 KB