• Takashi Iwai's avatar
    ALSA: hda/realtek - Reduce click noise on Dell Precision 5820 headphone · c0ca5ece
    Takashi Iwai authored
    Dell Precision 5820 with ALC3234 codec (which is equivalent with
    ALC255) shows click noises at (runtime) PM resume on the headphone.
    The biggest source of the noise comes from the cleared headphone pin
    control at resume, which is done via the standard shutup procedure.
    
    Although we have an override of the standard shutup callback to
    replace with NOP, this would skip other needed stuff (e.g. the pull
    down of headset power).  So, instead, this "fixes" the behavior of
    alc_fixup_no_shutup() by introducing spec->no_shutup_pins flag.
    When this flag is set, Realtek codec won't call the standard
    snd_hda_shutup_pins() & co.  Now alc_fixup_no_shutup() just sets this
    flag instead of overriding spec->shutup callback itself.  This allows
    us to apply the similar fix for other entries easily if needed in
    future.
    
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    c0ca5ece
patch_realtek.c 263 KB