• Chen Gang's avatar
    wil6210: use 'uint64_t' instead of 'cycles_t' to avoid warnings · c20e7789
    Chen Gang authored
    do_div() checks the type strictly. 'cycles_t' may be 32-bit under quite
    a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' instead
    of, the related warning (with allmodconfig under parisc):
    
        CC [M]  drivers/net/wireless/ath/wil6210/debugfs.o
      In file included from arch/parisc/include/generated/asm/div64.h:1:0,
                       from include/linux/kernel.h:124,
                       from include/linux/list.h:8,
                       from include/linux/module.h:9,
                       from drivers/net/wireless/ath/wil6210/debugfs.c:17:
      drivers/net/wireless/ath/wil6210/debugfs.c: In function ‘wil_vring_debugfs_show’:
      include/asm-generic/div64.h:43:28: warning: comparison of distinct pointer types lacks a cast
        (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                                  ^
      drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansion of macro ‘do_div’
          do_div(idle, total);
          ^
      In file included from include/uapi/linux/stddef.h:1:0,
                       from include/linux/stddef.h:4,
                       from ./include/uapi/linux/posix_types.h:4,
                       from include/uapi/linux/types.h:13,
                       from include/linux/types.h:5,
                       from include/linux/list.h:4,
                       from include/linux/module.h:9,
                       from drivers/net/wireless/ath/wil6210/debugfs.c:17:
      include/asm-generic/div64.h:44:18: warning: right shift count >= width of type [-Wshift-count-overflow]
        if (likely(((n) >> 32) == 0)) {   \
                        ^
      include/linux/compiler.h:159:40: note: in definition of macro ‘likely’
       # define likely(x) __builtin_expect(!!(x), 1)
                                              ^
      drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansion of macro ‘do_div’
          do_div(idle, total);
          ^
      In file included from arch/parisc/include/generated/asm/div64.h:1:0,
                       from include/linux/kernel.h:124,
                       from include/linux/list.h:8,
                       from include/linux/module.h:9,
                       from drivers/net/wireless/ath/wil6210/debugfs.c:17:
      include/asm-generic/div64.h:48:22: warning: passing argument 1 of ‘__div64_32’ from incompatible pointer type [-Wincompatible-pointer-types]
         __rem = __div64_32(&(n), __base); \
                            ^
      drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansion of macro ‘do_div’
          do_div(idle, total);
          ^
      include/asm-generic/div64.h:35:17: note: expected ‘uint64_t * {aka long long unsigned int *}’ but argument is of type ‘cycles_t * {aka long unsigned int *}’
       extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
                       ^
    Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    c20e7789
debugfs.c 32.4 KB