• Willem de Bruijn's avatar
    icmp: revise rfc4884 tests · c4e9e09f
    Willem de Bruijn authored
    1) Only accept packets with original datagram len field >= header len.
    
    The extension header must start after the original datagram headers.
    The embedded datagram len field is compared against the 128B minimum
    stipulated by RFC 4884. It is unlikely that headers extend beyond
    this. But as we know the exact header length, check explicitly.
    
    2) Remove the check that datagram length must be <= 576B.
    
    This is a send constraint. There is no value in testing this on rx.
    Within private networks it may be known safe to send larger packets.
    Process these packets.
    
    This test was also too lax. It compared original datagram length
    rather than entire icmp packet length. The stand-alone fix would be:
    
      -       if (hlen + skb->len > 576)
      +       if (-skb_network_offset(skb) + skb->len > 576)
    
    Fixes: eba75c58 ("icmp: support rfc 4884")
    Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c4e9e09f
icmp.c 32.1 KB