• Cheng Renquan's avatar
    md: need another print_sb for mdp_superblock_1 · cd2ac932
    Cheng Renquan authored
    md_print_devices is called in two code path: MD_BUG(...), and md_ioctl
    with PRINT_RAID_DEBUG.  it will dump out all in use md devices
    information;
    
    However, it wrongly processed two types of superblock in one:
    
    The header file <linux/raid/md_p.h> has defined two types of superblock,
    struct mdp_superblock_s (typedefed with mdp_super_t) according to md with
    metadata 0.90, and struct mdp_superblock_1 according to md with metadata
    1.0 and later,
    
    These two types of superblock are very different,
    
    The md_print_devices code processed them both in mdp_super_t, that would
    lead to wrong informaton dump like:
    
    	[ 6742.345877]
    	[ 6742.345887] md:	**********************************
    	[ 6742.345890] md:	* <COMPLETE RAID STATE PRINTOUT> *
    	[ 6742.345892] md:	**********************************
    	[ 6742.345896] md1: <ram7><ram6><ram5><ram4>
    	[ 6742.345907] md: rdev ram7, SZ:00065472 F:0 S:1 DN:3
    	[ 6742.345909] md: rdev superblock:
    	[ 6742.345914] md:  SB: (V:0.90.0) ID:<42ef13c7.598c059a.5f9f1645.801e9ee6> CT:4919856d
    	[ 6742.345918] md:     L5 S00065472 ND:4 RD:4 md1 LO:2 CS:65536
    	[ 6742.345922] md:     UT:4919856d ST:1 AD:4 WD:4 FD:0 SD:0 CSUM:b7992907 E:00000001
    	[ 6742.345924]      D  0:  DISK<N:0,(1,8),R:0,S:6>
    	[ 6742.345930]      D  1:  DISK<N:1,(1,10),R:1,S:6>
    	[ 6742.345933]      D  2:  DISK<N:2,(1,12),R:2,S:6>
    	[ 6742.345937]      D  3:  DISK<N:3,(1,14),R:3,S:6>
    	[ 6742.345942] md:     THIS:  DISK<N:3,(1,14),R:3,S:6>
    	...
    	[ 6742.346058] md0: <ram3><ram2><ram1><ram0>
    	[ 6742.346067] md: rdev ram3, SZ:00065472 F:0 S:1 DN:3
    	[ 6742.346070] md: rdev superblock:
    	[ 6742.346073] md:  SB: (V:1.0.0) ID:<369aad81.00000000.00000000.00000000> CT:9a322a9c
    	[ 6742.346077] md:     L-1507699579 S976570180 ND:48 RD:0 md0 LO:65536 CS:196610
    	[ 6742.346081] md:     UT:00000018 ST:0 AD:131048 WD:0 FD:8 SD:0 CSUM:00000000 E:00000000
    	[ 6742.346084]      D  0:  DISK<N:-1,(-1,-1),R:-1,S:-1>
    	[ 6742.346089]      D  1:  DISK<N:-1,(-1,-1),R:-1,S:-1>
    	[ 6742.346092]      D  2:  DISK<N:-1,(-1,-1),R:-1,S:-1>
    	[ 6742.346096]      D  3:  DISK<N:-1,(-1,-1),R:-1,S:-1>
    	[ 6742.346102] md:     THIS:  DISK<N:0,(0,0),R:0,S:0>
    	...
    	[ 6742.346219] md:	**********************************
    	[ 6742.346221]
    
    Here md1 is metadata 0.90.0, and md0 is metadata 1.2
    
    After some more code to distinguish these two types of superblock, in this patch,
    
    it will generate dump information like:
    
    	[ 7906.755790]
    	[ 7906.755799] md:	**********************************
    	[ 7906.755802] md:	* <COMPLETE RAID STATE PRINTOUT> *
    	[ 7906.755804] md:	**********************************
    	[ 7906.755808] md1: <ram7><ram6><ram5><ram4>
    	[ 7906.755819] md: rdev ram7, SZ:00065472 F:0 S:1 DN:3
    	[ 7906.755821] md: rdev superblock (MJ:0):
    	[ 7906.755826] md:  SB: (V:0.90.0) ID:<3fca7a0d.a612bfed.5f9f1645.801e9ee6> CT:491989f3
    	[ 7906.755830] md:     L5 S00065472 ND:4 RD:4 md1 LO:2 CS:65536
    	[ 7906.755834] md:     UT:491989f3 ST:1 AD:4 WD:4 FD:0 SD:0 CSUM:00fb52ad E:00000001
    	[ 7906.755836]      D  0:  DISK<N:0,(1,8),R:0,S:6>
    	[ 7906.755842]      D  1:  DISK<N:1,(1,10),R:1,S:6>
    	[ 7906.755845]      D  2:  DISK<N:2,(1,12),R:2,S:6>
    	[ 7906.755849]      D  3:  DISK<N:3,(1,14),R:3,S:6>
    	[ 7906.755855] md:     THIS:  DISK<N:3,(1,14),R:3,S:6>
    	...
    	[ 7906.755972] md0: <ram3><ram2><ram1><ram0>
    	[ 7906.755981] md: rdev ram3, SZ:00065472 F:0 S:1 DN:3
    	[ 7906.755984] md: rdev superblock (MJ:1):
    	[ 7906.755989] md:  SB: (V:1) (F:0) Array-ID:<5fbcf158:55aa:5fbe:9a79:1e939880dcbd>
    	[ 7906.755990] md:    Name: "DG5:0" CT:1226410480
    	[ 7906.755998] md:       L5 SZ130944 RD:4 LO:2 CS:128 DO:24 DS:131048 SO:8 RO:0
    	[ 7906.755999] md:     Dev:00000003 UUID: 9194d744:87f7:a448:85f2:7497b84ce30a
    	[ 7906.756001] md:       (F:0) UT:1226410480 Events:0 ResyncOffset:-1 CSUM:0dbcd829
    	[ 7906.756003] md:         (MaxDev:384)
    	...
    	[ 7906.756113] md:	**********************************
    	[ 7906.756116]
    
    this md0 (metadata 1.2) information dumping is exactly according to struct
    mdp_superblock_1.
    Signed-off-by: default avatarCheng Renquan <crquan@gmail.com>
    Cc: Neil Brown <neilb@suse.de>
    Cc: Dan Williams <dan.j.williams@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    cd2ac932
md.c 164 KB