• Larry Finger's avatar
    staging: rtl8723bs: Fix incorrect sense of ether_addr_equal · c948c691
    Larry Finger authored
    In commit b37f9e1c ("staging: rtl8723bs: Fix lines too long in
    update_recvframe_attrib()."), the refactoring involved replacing
    two memcmp() calls with ether_addr_equal() calls. What the author
    missed is that memcmp() returns false when the two strings are equal,
    whereas ether_addr_equal() returns true when the two addresses are
    equal. One side effect of this error is that the strength of an
    unassociated AP was much stronger than the same AP after association.
    This bug is reported at bko#201611.
    
    Fixes: b37f9e1c ("staging: rtl8723bs: Fix lines too long in update_recvframe_attrib().")
    Cc: Stable <stable@vger.kernel.org>
    Cc: youling257 <youling257@gmail.com>
    Cc: u.srikant.patnaik@gmail.com
    Reported-and-tested-by: default avataryouling257 <youling257@gmail.com>
    Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c948c691
rtl8723bs_recv.c 14.6 KB