• Dave Hansen's avatar
    x86/pti: Fix boot problems from Global-bit setting · d2479a30
    Dave Hansen authored
    commit 16dce603adc9de4237b7bf2ff5c5290f34373e7b
    
    Part of the global bit _setting_ patches also includes clearing the
    Global bit when it should not be enabled.  That is done with
    set_memory_nonglobal(), which uses change_page_attr_clear() in
    pageattr.c under the covers.
    
    The TLB flushing code inside pageattr.c has has checks like
    BUG_ON(irqs_disabled()), looking for interrupt disabling that might
    cause deadlocks.  But, these also trip in early boot on certain
    preempt configurations.  Just copy the existing BUG_ON() sequence from
    cpa_flush_range() to the other two sites and check for early boot.
    
    Fixes: 39114b7a (x86/pti: Never implicitly clear _PAGE_GLOBAL for kernel image)
    Reported-by: default avatarMariusz Ceier <mceier@gmail.com>
    Reported-by: default avatarAaro Koskinen <aaro.koskinen@nokia.com>
    Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Tested-by: default avatarAaro Koskinen <aaro.koskinen@nokia.com>
    Acked-by: default avatarIngo Molnar <mingo@kernel.org>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Juergen Gross <jgross@suse.com>
    Cc: Nadav Amit <namit@vmware.com>
    Cc: Kees Cook <keescook@google.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: linux-mm@kvack.org
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Arjan van de Ven <arjan@linux.intel.com>
    Link: https://lkml.kernel.org/r/20180420222019.20C4A410@viggo.jf.intel.com
    
    d2479a30
pageattr.c 49.9 KB