• Neil Brown's avatar
    Fix race related problem when adding items to and svcrpc auth cache. · d267cf77
    Neil Brown authored
    Fix race related problem when adding items to and svcrpc auth cache.
    
    If we don't find the item we are lookng for, we allocate a new one,
    and then grab the lock again and search to see if it has been added
    while we did the alloc.
    If it had been added we need to 'cache_put' the newly created item
    that we are never going to use.  But as it hasn't been initialised
    properly, putting it can cause an oops.
    
    So move the ->init call earlier to that it will always be fully
    initilised if we have to put it.
    
    Thanks to Philipp Matthias Hahn <pmhahn@svs.Informatik.Uni-Oldenburg.de>
    for reporting the problem.
    Signed-off-by: default avatarNeil Brown <neilb@suse.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    
    d267cf77
cache.c 30.1 KB