• Mahesh Bandewar's avatar
    loopback: fix lockdep splat · d62962b3
    Mahesh Bandewar authored
    dev_init_scheduler() and dev_activate() expect the caller to
    hold RTNL. Since we don't want blackhole device to be initialized
    per ns, we are initializing at init.
    
    [    3.855027] Call Trace:
    [    3.855034]  dump_stack+0x67/0x95
    [    3.855037]  lockdep_rcu_suspicious+0xd5/0x110
    [    3.855044]  dev_init_scheduler+0xe3/0x120
    [    3.855048]  ? net_olddevs_init+0x60/0x60
    [    3.855050]  blackhole_netdev_init+0x45/0x6e
    [    3.855052]  do_one_initcall+0x6c/0x2fa
    [    3.855058]  ? rcu_read_lock_sched_held+0x8c/0xa0
    [    3.855066]  kernel_init_freeable+0x1e5/0x288
    [    3.855071]  ? rest_init+0x260/0x260
    [    3.855074]  kernel_init+0xf/0x180
    [    3.855076]  ? rest_init+0x260/0x260
    [    3.855078]  ret_from_fork+0x24/0x30
    
    Fixes: 4de83b88 ("loopback: create blackhole net device similar to loopack.")
    Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Cc: Eric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarMahesh Bandewar <maheshb@google.com>
    Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d62962b3
loopback.c 7.08 KB