• Matti Linnanvuori's avatar
    [NET]: Fix race in dev_close(). (Bug 9750) · d8b2a4d2
    Matti Linnanvuori authored
    There is a race in Linux kernel file net/core/dev.c, function dev_close.
    The function calls function dev_deactivate, which calls function
    dev_watchdog_down that deletes the watchdog timer. However, after that, a
    driver can call netif_carrier_ok, which calls function
    __netdev_watchdog_up that can add the watchdog timer again. Function
    unregister_netdevice calls function dev_shutdown that traps the bug
    !timer_pending(&dev->watchdog_timer). Moving dev_deactivate after
    netif_running() has been cleared prevents function netif_carrier_on
    from calling __netdev_watchdog_up and adding the watchdog timer again.
    Signed-off-by: default avatarMatti Linnanvuori <mattilinnanvuori@yahoo.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d8b2a4d2
dev.c 111 KB