• Julia Lawall's avatar
    thermal: hwmon: use permission-specific DEVICE_ATTR variants · de6b0c1a
    Julia Lawall authored
    Use DEVICE_ATTR_RO for read only attributes.  This simplifies the
    source code, improves readbility, and reduces the chance of
    inconsistencies.
    
    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @ro@
    declarer name DEVICE_ATTR;
    identifier x,x_show;
    @@
    
    DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
    
    @script:ocaml@
    x << ro.x;
    x_show << ro.x_show;
    @@
    
    if not (x^"_show" = x_show) then Coccilib.include_match false
    
    @@
    declarer name DEVICE_ATTR_RO;
    identifier ro.x,ro.x_show;
    @@
    
    - DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
    + DEVICE_ATTR_RO(x);
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
    de6b0c1a
thermal_hwmon.c 7.5 KB