• Christoph Hellwig's avatar
    sctp: fix slab-out-of-bounds in SCTP_DELAYED_SACK processing · dfd3d526
    Christoph Hellwig authored
    This sockopt accepts two kinds of parameters, using struct
    sctp_sack_info and struct sctp_assoc_value. The mentioned commit didn't
    notice an implicit cast from the smaller (latter) struct to the bigger
    one (former) when copying the data from the user space, which now leads
    to an attempt to write beyond the buffer (because it assumes the storing
    buffer is bigger than the parameter itself).
    
    Fix it by allocating a sctp_sack_info on stack and filling it out based
    on the small struct for the compat case.
    
    Changelog stole from an earlier patch from Marcelo Ricardo Leitner.
    
    Fixes: ebb25def ("sctp: pass a kernel pointer to sctp_setsockopt_delayed_ack")
    Reported-by: syzbot+0e4699d000d8b874d8dc@syzkaller.appspotmail.com
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    dfd3d526
socket.c 259 KB