• Uri Shkolnik's avatar
    V4L/DVB (10750): import changes from Siano · e0f14c25
    Uri Shkolnik authored
    Import the following changes from Uri Shkolnik
    
    * Two-ways merge with Siano internal repository
    * Continuing with DVB sub-system separation
    * kconfig and makefile updates
    * Code cleanup
    
    This is a work-in-progress sync with Siano's internal repository.
    
    Some changes had to be altered or dropped in order not to break the build.
    
    This breaks normal operation for the current driver, but it is being committed
    now for tracking purposes.
    
    These changes introduce the following checkpatch.pl violations:
    
    ERROR: do not use C99 // comments
    156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
    +//#ifdef DVB_CORE
    
    ERROR: do not use C99 // comments
    157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
    +//	smsdvb_unregister();
    
    ERROR: do not use C99 // comments
    158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
    +//#endif
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
    +EXPORT_SYMBOL(smscore_onresponse);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
    +EXPORT_SYMBOL(sms_get_board);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
    +EXPORT_SYMBOL(sms_debug);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
    +EXPORT_SYMBOL(smscore_putbuffer);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
    +EXPORT_SYMBOL(smscore_registry_getmode);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
    +EXPORT_SYMBOL(smscore_register_device);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
    +EXPORT_SYMBOL(smscore_set_board_id);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
    +EXPORT_SYMBOL(smscore_start_device);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
    +EXPORT_SYMBOL(smsusb_id_table);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
    +EXPORT_SYMBOL(smscore_unregister_device);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
    +EXPORT_SYMBOL(smscore_getbuffer);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
    +EXPORT_SYMBOL(smscore_get_device_mode);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
    +EXPORT_SYMBOL(smscore_register_client);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
    +EXPORT_SYMBOL(smscore_unregister_hotplug);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
    +EXPORT_SYMBOL(smsclient_sendrequest);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
    +EXPORT_SYMBOL(smscore_unregister_client);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
    +EXPORT_SYMBOL(smscore_get_board_id);
    
    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
    180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
    +EXPORT_SYMBOL(smscore_register_hotplug);
    
    WARNING: line over 80 characters
    391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
    +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
    
    ERROR: "foo* bar" should be "foo *bar"
    391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
    +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
    
    WARNING: line over 80 characters
    392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
    +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
    
    ERROR: "foo* bar" should be "foo *bar"
    392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
    +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
    
    ERROR: space required after that ',' (ctx:VxV)
    392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
    +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                 ^
    
    WARNING: __func__ should be used instead of gcc specific __FUNCTION__
    489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
    +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
    
    WARNING: __func__ should be used instead of gcc specific __FUNCTION__
    501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
    +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
    
    ERROR: space prohibited before that '++' (ctx:WxB)
    505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
    +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
     	                                                            ^
    
    WARNING: __func__ should be used instead of gcc specific __FUNCTION__
    517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
    +			__FUNCTION__, rc);
    
    total: 7 errors, 23 warnings, 524 lines checked
    Signed-off-by: default avatarUri Shkolnik <uris@siano-ms.com>
    Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    e0f14c25
Makefile 275 Bytes