• Marc Dionne's avatar
    rxrpc: Fix resend event time calculation · 59299aa1
    Marc Dionne authored
    Commit a158bdd3 ("rxrpc: Fix call timeouts") reworked the time calculation
    for the next resend event.  For this calculation, "oldest" will be before
    "now", so ktime_sub(oldest, now) will yield a negative value.  When passed
    to nsecs_to_jiffies which expects an unsigned value, the end result will be
    a very large value, and a resend event scheduled far into the future.  This
    could cause calls to stall if some packets were lost.
    
    Fix by ordering the arguments to ktime_sub correctly.
    
    Fixes: a158bdd3 ("rxrpc: Fix call timeouts")
    Signed-off-by: default avatarMarc Dionne <marc.dionne@auristor.com>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    59299aa1
call_event.c 12.5 KB