• Steven Rostedt's avatar
    sched: Remove unlikely() from ttwu_post_activation · e69c6341
    Steven Rostedt authored
    The unlikely() used in ttwu_post_activation() tests if the rq->idle_stamp
    is set. But since this is for a wakeup, and wakeups happen when tasks
    block on IO, and blocking tasks on IO may put the system into idle,
    this can actually be a common occurence.
    
    Running the annotated branch profiler on an average desktop running
    firefox, evolution, xchat and distcc, the report shows:
    
     correct incorrect  %        Function             File              Line
     ------- ---------  -        --------             ----              ----
    34884862 146110926  80 ttwu_post_activation      sched.c            2309
    
    80% of the time, this unlikely is incorrect. Best not to assume what the
    result is, and just remove the branch annotation.
    
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    e69c6341
sched.c 226 KB