• Julia Lawall's avatar
    V4L/DVB (13166): remove duplicate structure field initialization · e6a1a08f
    Julia Lawall authored
    The definition of tvaudio_tuner_ops initializes the s_tuner field twice.
    It appears that the second case should initialize the g_tuner field.
    
    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r@
    identifier I, s, fld;
    position p0,p;
    expression E;
    @@
    
    struct I s =@p0 { ... .fld@p = E, ...};
    
    @s@
    identifier I, s, r.fld;
    position r.p0,p;
    expression E;
    @@
    
    struct I s =@p0 { ... .fld@p = E, ...};
    
    @script:python@
    p0 << r.p0;
    fld << r.fld;
    ps << s.p;
    pr << r.p;
    @@
    
    if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
      cocci.print_main(fld,p0)
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    e6a1a08f
tvaudio.c 62.3 KB