• Marco Elver's avatar
    bitops, kcsan: Partially revert instrumentation for non-atomic bitops · 068df053
    Marco Elver authored
    Previous to the change to distinguish read-write accesses, when
    CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=y is set, KCSAN would consider
    the non-atomic bitops as atomic. We want to partially revert to this
    behaviour, but with one important distinction: report racing
    modifications, since lost bits due to non-atomicity are certainly
    possible.
    
    Given the operations here only modify a single bit, assuming
    non-atomicity of the writer is sufficient may be reasonable for certain
    usage (and follows the permissible nature of the "assume plain writes
    atomic" rule). In other words:
    
    	1. We want non-atomic read-modify-write races to be reported;
    	   this is accomplished by kcsan_check_read(), where any
    	   concurrent write (atomic or not) will generate a report.
    
    	2. We do not want to report races with marked readers, but -do-
    	   want to report races with unmarked readers; this is
    	   accomplished by the instrument_write() ("assume atomic
    	   write" with Kconfig option set).
    
    With the above rules, when KCSAN_ASSUME_PLAIN_WRITES_ATOMIC is selected,
    it is hoped that KCSAN's reporting behaviour is better aligned with
    current expected permissible usage for non-atomic bitops.
    
    Note that, a side-effect of not telling KCSAN that the accesses are
    read-writes, is that this information is not displayed in the access
    summary in the report. It is, however, visible in inline-expanded stack
    traces. For now, it does not make sense to introduce yet another special
    case to KCSAN's runtime, only to cater to the case here.
    
    Cc: Dmitry Vyukov <dvyukov@google.com>
    Cc: Paul E. McKenney <paulmck@kernel.org>
    Cc: Will Deacon <will@kernel.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Daniel Axtens <dja@axtens.net>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: <linux-arch@vger.kernel.org>
    Signed-off-by: default avatarMarco Elver <elver@google.com>
    Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    068df053
instrumented-non-atomic.h 4.25 KB