• Gustavo A. R. Silva's avatar
    ima: ima_api: Use struct_size() in kzalloc() · 2a7f0e53
    Gustavo A. R. Silva authored
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct ima_template_entry {
    	...
            struct ima_field_data template_data[0]; /* template related data */
    };
    
    instance = kzalloc(sizeof(struct ima_template_entry) + count * sizeof(struct ima_field_data), GFP_NOFS);
    
    Instead of leaving these open-coded and prone to type mistakes, we can
    now use the new struct_size() helper:
    
    instance = kzalloc(struct_size(instance, entry, count), GFP_NOFS);
    
    This code was detected with the help of Coccinelle.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
    2a7f0e53
ima_api.c 11.1 KB