• David Ahern's avatar
    perf symbols: Fix builds with NO_LIBELF set · f47b58b7
    David Ahern authored
    Build currently fails:
      $ make -C tools/perf O=/tmp/pbuild NO_LIBELF=1
    
      util/symbol.c: In function ‘dso__load’:
      util/symbol.c:1128:27: error: ‘struct symsrc’ has no member named ‘dynsym’
          CC /tmp/pbuild/util/pager.o
      make: *** [/tmp/pbuild/util/symbol.o] Error 1
      make: *** Waiting for unfinished jobs....
    
    Moving the dynsym reference to symbol-elf.c reveals that NO_LIBELF requires
    NO_LIBUNWIND:
    
      $ make -C tools/perf O=/tmp/pbuild NO_LIBELF=1
    
          LINK /tmp/pbuild/perf
      /tmp/pbuild/libperf.a(unwind.o): In function `elf_section_offset':
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:176: undefined reference to `elf_begin'
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:181: undefined reference to `gelf_getehdr'
      /tmp/pbuild/libperf.a(unwind.o): In function `elf_section_by_name':
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:157: undefined reference to `elf_nextscn'
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:160: undefined reference to `gelf_getshdr'
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:161: undefined reference to `elf_strptr'
      /tmp/pbuild/libperf.a(unwind.o): In function `elf_section_offset':
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:190: undefined reference to `elf_end'
      /tmp/pbuild/libperf.a(unwind.o): In function `read_unwind_spec':
      /opt/sw/ahern/perf.git/tools/perf/util/unwind.c:190: undefined reference to `elf_end'
      collect2: ld returned 1 exit status
      make: *** [/tmp/pbuild/perf] Error 1
      make: Leaving directory `/opt/sw/ahern/perf.git/tools/perf'
    
    This patch fixes both.
    Reviewed-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: http://lkml.kernel.org/r/1345391234-71906-1-git-send-email-dsahern@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    f47b58b7
symbol-elf.c 18.6 KB