• Al Viro's avatar
    [PATCH] sanitize locate_fd() · f8f95702
    Al Viro authored
    * 'file' argument is unused; lose it.
    * move setting flags from the caller (dupfd()) to locate_fd();
      pass cloexec flag as new argument.  Note that files_fdtable()
      that used to be in dupfd() isn't needed in the place in
      locate_fd() where the moved code ends up - we know that ->file_lock
      hadn't been dropped since the last time we calculated fdt because
      we can get there only if expand_files() returns 0 and it doesn't
      drop/reacquire in that case.
    * move getting/dropping ->file_lock into locate_fd().  Now the caller
      doesn't need to do anything with files_struct *files anymore and
      we can move that inside locate_fd() as well, killing the
      struct files_struct * argument.
    
    At that point locate_fd() is extremely similar to get_unused_fd_flags()
    and the next patches will merge those two.
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    f8f95702
fcntl.c 14 KB