• Jean Delvare's avatar
    i2c-piix4: Various cleanups and minor fixes · fa63cd56
    Jean Delvare authored
    The i2c-piix4 driver was used recently as a model to write a new SMBus
    host controller driver and this made me realize that the code of this
    old driver wasn't exactly good. So, here are many cleanups and minor
    fixes to this driver, so that these minor mistakes aren't duplicated
    again:
    
    * Delete unused structure.
    * Delete needless forward function declaration.
    * Properly announce the SMBus host controller as we find it.
    * Spell it SMBus not SMB.
    * Return -EBUSY instead of -ENODEV when the I/O region is already in
      use.
    * Drop useless masks on the 7-bit address and the R/W bit.
    * Reject block transaction requests with an invalid block length.
    * Check and report block transaction replies with an invalid block
      length.
    * Delete a useless comment.
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    fa63cd56
i2c-piix4.c 13.4 KB