Commit 00690008 authored by Lucas De Marchi's avatar Lucas De Marchi Committed by Rodrigo Vivi

drm/i915: Rename IS_GEN to IS_GEN_RANGE

RANGE makes it longer, but clearer. We are also going to add a macro to
check an individual gen, so add the _RANGE prefix here.

Diff generated with:

sed 's/IS_GEN(/IS_GEN_RANGE(/g' drivers/gpu/drm/i915/{*/,}*.{c,h} -i

v2: use IS_GEN rather than GT_GEN
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181212181044.15886-1-lucas.demarchi@intel.com
parent 25db2eaf
...@@ -2211,7 +2211,7 @@ intel_info(const struct drm_i915_private *dev_priv) ...@@ -2211,7 +2211,7 @@ intel_info(const struct drm_i915_private *dev_priv)
GENMASK((e) - 1, (s) - 1)) GENMASK((e) - 1, (s) - 1))
/* Returns true if Gen is in inclusive range [Start, End] */ /* Returns true if Gen is in inclusive range [Start, End] */
#define IS_GEN(dev_priv, s, e) \ #define IS_GEN_RANGE(dev_priv, s, e) \
(!!((dev_priv)->info.gen_mask & INTEL_GEN_MASK((s), (e)))) (!!((dev_priv)->info.gen_mask & INTEL_GEN_MASK((s), (e))))
/* /*
......
...@@ -1796,7 +1796,7 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream) ...@@ -1796,7 +1796,7 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream)
* be read back from automatically triggered reports, as part of the * be read back from automatically triggered reports, as part of the
* RPT_ID field. * RPT_ID field.
*/ */
if (IS_GEN(dev_priv, 9, 11)) { if (IS_GEN_RANGE(dev_priv, 9, 11)) {
I915_WRITE(GEN8_OA_DEBUG, I915_WRITE(GEN8_OA_DEBUG,
_MASKED_BIT_ENABLE(GEN9_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS | _MASKED_BIT_ENABLE(GEN9_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
GEN9_OA_DEBUG_INCLUDE_CLK_RATIO)); GEN9_OA_DEBUG_INCLUDE_CLK_RATIO));
...@@ -3442,7 +3442,7 @@ void i915_perf_init(struct drm_i915_private *dev_priv) ...@@ -3442,7 +3442,7 @@ void i915_perf_init(struct drm_i915_private *dev_priv)
dev_priv->perf.oa.gen8_valid_ctx_bit = (1<<16); dev_priv->perf.oa.gen8_valid_ctx_bit = (1<<16);
} }
} else if (IS_GEN(dev_priv, 10, 11)) { } else if (IS_GEN_RANGE(dev_priv, 10, 11)) {
dev_priv->perf.oa.ops.is_valid_b_counter_reg = dev_priv->perf.oa.ops.is_valid_b_counter_reg =
gen7_is_valid_b_counter_addr; gen7_is_valid_b_counter_addr;
dev_priv->perf.oa.ops.is_valid_mux_reg = dev_priv->perf.oa.ops.is_valid_mux_reg =
......
...@@ -453,7 +453,7 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version) ...@@ -453,7 +453,7 @@ parse_sdvo_device_mapping(struct drm_i915_private *dev_priv, u8 bdb_version)
* Only parse SDVO mappings on gens that could have SDVO. This isn't * Only parse SDVO mappings on gens that could have SDVO. This isn't
* accurate and doesn't have to be, as long as it's not too strict. * accurate and doesn't have to be, as long as it's not too strict.
*/ */
if (!IS_GEN(dev_priv, 3, 7)) { if (!IS_GEN_RANGE(dev_priv, 3, 7)) {
DRM_DEBUG_KMS("Skipping SDVO device mapping\n"); DRM_DEBUG_KMS("Skipping SDVO device mapping\n");
return; return;
} }
......
...@@ -1248,7 +1248,7 @@ static void intel_engine_print_registers(const struct intel_engine_cs *engine, ...@@ -1248,7 +1248,7 @@ static void intel_engine_print_registers(const struct intel_engine_cs *engine,
&engine->execlists; &engine->execlists;
u64 addr; u64 addr;
if (engine->id == RCS && IS_GEN(dev_priv, 4, 7)) if (engine->id == RCS && IS_GEN_RANGE(dev_priv, 4, 7))
drm_printf(m, "\tCCID: 0x%08x\n", I915_READ(CCID)); drm_printf(m, "\tCCID: 0x%08x\n", I915_READ(CCID));
drm_printf(m, "\tRING_START: 0x%08x\n", drm_printf(m, "\tRING_START: 0x%08x\n",
I915_READ(RING_START(engine->mmio_base))); I915_READ(RING_START(engine->mmio_base)));
......
...@@ -787,7 +787,7 @@ static bool intel_fbc_can_activate(struct intel_crtc *crtc) ...@@ -787,7 +787,7 @@ static bool intel_fbc_can_activate(struct intel_crtc *crtc)
* having a Y offset that isn't divisible by 4 causes FIFO underrun * having a Y offset that isn't divisible by 4 causes FIFO underrun
* and screen flicker. * and screen flicker.
*/ */
if (IS_GEN(dev_priv, 9, 10) && if (IS_GEN_RANGE(dev_priv, 9, 10) &&
(fbc->state_cache.plane.adjusted_y & 3)) { (fbc->state_cache.plane.adjusted_y & 3)) {
fbc->no_fbc_reason = "plane Y offset is misaligned"; fbc->no_fbc_reason = "plane Y offset is misaligned";
return false; return false;
......
...@@ -252,7 +252,7 @@ engine_stuck(struct intel_engine_cs *engine, u64 acthd) ...@@ -252,7 +252,7 @@ engine_stuck(struct intel_engine_cs *engine, u64 acthd)
return ENGINE_WAIT_KICK; return ENGINE_WAIT_KICK;
} }
if (IS_GEN(dev_priv, 6, 7) && tmp & RING_WAIT_SEMAPHORE) { if (IS_GEN_RANGE(dev_priv, 6, 7) && tmp & RING_WAIT_SEMAPHORE) {
switch (semaphore_passed(engine)) { switch (semaphore_passed(engine)) {
default: default:
return ENGINE_DEAD; return ENGINE_DEAD;
......
...@@ -445,7 +445,7 @@ static void intel_ring_setup_status_page(struct intel_engine_cs *engine) ...@@ -445,7 +445,7 @@ static void intel_ring_setup_status_page(struct intel_engine_cs *engine)
POSTING_READ(mmio); POSTING_READ(mmio);
/* Flush the TLB for this page */ /* Flush the TLB for this page */
if (IS_GEN(dev_priv, 6, 7)) { if (IS_GEN_RANGE(dev_priv, 6, 7)) {
i915_reg_t reg = RING_INSTPM(engine->mmio_base); i915_reg_t reg = RING_INSTPM(engine->mmio_base);
/* ring should be idle before issuing a sync flush*/ /* ring should be idle before issuing a sync flush*/
...@@ -679,7 +679,7 @@ static int init_render_ring(struct intel_engine_cs *engine) ...@@ -679,7 +679,7 @@ static int init_render_ring(struct intel_engine_cs *engine)
return ret; return ret;
/* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */ /* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */
if (IS_GEN(dev_priv, 4, 6)) if (IS_GEN_RANGE(dev_priv, 4, 6))
I915_WRITE(MI_MODE, _MASKED_BIT_ENABLE(VS_TIMER_DISPATCH)); I915_WRITE(MI_MODE, _MASKED_BIT_ENABLE(VS_TIMER_DISPATCH));
/* We need to disable the AsyncFlip performance optimisations in order /* We need to disable the AsyncFlip performance optimisations in order
...@@ -688,7 +688,7 @@ static int init_render_ring(struct intel_engine_cs *engine) ...@@ -688,7 +688,7 @@ static int init_render_ring(struct intel_engine_cs *engine)
* *
* WaDisableAsyncFlipPerfMode:snb,ivb,hsw,vlv * WaDisableAsyncFlipPerfMode:snb,ivb,hsw,vlv
*/ */
if (IS_GEN(dev_priv, 6, 7)) if (IS_GEN_RANGE(dev_priv, 6, 7))
I915_WRITE(MI_MODE, _MASKED_BIT_ENABLE(ASYNC_FLIP_PERF_DISABLE)); I915_WRITE(MI_MODE, _MASKED_BIT_ENABLE(ASYNC_FLIP_PERF_DISABLE));
/* Required for the hardware to program scanline values for waiting */ /* Required for the hardware to program scanline values for waiting */
...@@ -713,7 +713,7 @@ static int init_render_ring(struct intel_engine_cs *engine) ...@@ -713,7 +713,7 @@ static int init_render_ring(struct intel_engine_cs *engine)
_MASKED_BIT_DISABLE(CM0_STC_EVICT_DISABLE_LRA_SNB)); _MASKED_BIT_DISABLE(CM0_STC_EVICT_DISABLE_LRA_SNB));
} }
if (IS_GEN(dev_priv, 6, 7)) if (IS_GEN_RANGE(dev_priv, 6, 7))
I915_WRITE(INSTPM, _MASKED_BIT_ENABLE(INSTPM_FORCE_ORDERING)); I915_WRITE(INSTPM, _MASKED_BIT_ENABLE(INSTPM_FORCE_ORDERING));
if (INTEL_GEN(dev_priv) >= 6) if (INTEL_GEN(dev_priv) >= 6)
......
...@@ -1567,13 +1567,13 @@ void intel_uncore_init(struct drm_i915_private *dev_priv) ...@@ -1567,13 +1567,13 @@ void intel_uncore_init(struct drm_i915_private *dev_priv)
dev_priv->uncore.pmic_bus_access_nb.notifier_call = dev_priv->uncore.pmic_bus_access_nb.notifier_call =
i915_pmic_bus_access_notifier; i915_pmic_bus_access_notifier;
if (IS_GEN(dev_priv, 2, 4) || intel_vgpu_active(dev_priv)) { if (IS_GEN_RANGE(dev_priv, 2, 4) || intel_vgpu_active(dev_priv)) {
ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen2); ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen2);
ASSIGN_READ_MMIO_VFUNCS(dev_priv, gen2); ASSIGN_READ_MMIO_VFUNCS(dev_priv, gen2);
} else if (IS_GEN5(dev_priv)) { } else if (IS_GEN5(dev_priv)) {
ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen5); ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen5);
ASSIGN_READ_MMIO_VFUNCS(dev_priv, gen5); ASSIGN_READ_MMIO_VFUNCS(dev_priv, gen5);
} else if (IS_GEN(dev_priv, 6, 7)) { } else if (IS_GEN_RANGE(dev_priv, 6, 7)) {
ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen6); ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen6);
if (IS_VALLEYVIEW(dev_priv)) { if (IS_VALLEYVIEW(dev_priv)) {
...@@ -1592,7 +1592,7 @@ void intel_uncore_init(struct drm_i915_private *dev_priv) ...@@ -1592,7 +1592,7 @@ void intel_uncore_init(struct drm_i915_private *dev_priv)
ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen8); ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, gen8);
ASSIGN_READ_MMIO_VFUNCS(dev_priv, gen6); ASSIGN_READ_MMIO_VFUNCS(dev_priv, gen6);
} }
} else if (IS_GEN(dev_priv, 9, 10)) { } else if (IS_GEN_RANGE(dev_priv, 9, 10)) {
ASSIGN_FW_DOMAINS_TABLE(__gen9_fw_ranges); ASSIGN_FW_DOMAINS_TABLE(__gen9_fw_ranges);
ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, fwtable); ASSIGN_WRITE_MMIO_VFUNCS(dev_priv, fwtable);
ASSIGN_READ_MMIO_VFUNCS(dev_priv, fwtable); ASSIGN_READ_MMIO_VFUNCS(dev_priv, fwtable);
...@@ -2321,7 +2321,7 @@ intel_uncore_forcewake_for_read(struct drm_i915_private *dev_priv, ...@@ -2321,7 +2321,7 @@ intel_uncore_forcewake_for_read(struct drm_i915_private *dev_priv,
} else if (INTEL_GEN(dev_priv) >= 6) { } else if (INTEL_GEN(dev_priv) >= 6) {
fw_domains = __gen6_reg_read_fw_domains(offset); fw_domains = __gen6_reg_read_fw_domains(offset);
} else { } else {
WARN_ON(!IS_GEN(dev_priv, 2, 5)); WARN_ON(!IS_GEN_RANGE(dev_priv, 2, 5));
fw_domains = 0; fw_domains = 0;
} }
...@@ -2343,10 +2343,10 @@ intel_uncore_forcewake_for_write(struct drm_i915_private *dev_priv, ...@@ -2343,10 +2343,10 @@ intel_uncore_forcewake_for_write(struct drm_i915_private *dev_priv,
fw_domains = __fwtable_reg_write_fw_domains(offset); fw_domains = __fwtable_reg_write_fw_domains(offset);
} else if (IS_GEN8(dev_priv)) { } else if (IS_GEN8(dev_priv)) {
fw_domains = __gen8_reg_write_fw_domains(offset); fw_domains = __gen8_reg_write_fw_domains(offset);
} else if (IS_GEN(dev_priv, 6, 7)) { } else if (IS_GEN_RANGE(dev_priv, 6, 7)) {
fw_domains = FORCEWAKE_RENDER; fw_domains = FORCEWAKE_RENDER;
} else { } else {
WARN_ON(!IS_GEN(dev_priv, 2, 5)); WARN_ON(!IS_GEN_RANGE(dev_priv, 2, 5));
fw_domains = 0; fw_domains = 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment