Commit 03c9c8fa authored by Amit Daniel Kachhap's avatar Amit Daniel Kachhap Committed by Will Deacon

arm64: kprobe: clarify the comment of steppable hint instructions

The existing comment about steppable hint instruction is not complete
and only describes NOP instructions as steppable. As the function
aarch64_insn_is_steppable_hint allows all white-listed instruction
to be probed so the comment is updated to reflect this.
Signed-off-by: default avatarAmit Daniel Kachhap <amit.kachhap@arm.com>
Reviewed-by: default avatarDave Martin <dave.martin@arm.com>
Link: https://lore.kernel.org/r/20200914083656.21428-7-amit.kachhap@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent 6560edca
...@@ -43,8 +43,10 @@ static bool __kprobes aarch64_insn_is_steppable(u32 insn) ...@@ -43,8 +43,10 @@ static bool __kprobes aarch64_insn_is_steppable(u32 insn)
!= AARCH64_INSN_SPCLREG_DAIF; != AARCH64_INSN_SPCLREG_DAIF;
/* /*
* The HINT instruction is is problematic when single-stepping, * The HINT instruction is steppable only if it is in whitelist
* except for the NOP case. * and the rest of other such instructions are blocked for
* single stepping as they may cause exception or other
* unintended behaviour.
*/ */
if (aarch64_insn_is_hint(insn)) if (aarch64_insn_is_hint(insn))
return aarch64_insn_is_steppable_hint(insn); return aarch64_insn_is_steppable_hint(insn);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment