Commit 0c871f9a authored by Brian Foster's avatar Brian Foster Committed by Dave Chinner

xfs: remove spurious shutdown type check from xfs_bmap_finish()

The static checker reports that after commit 8d99fe92 ("xfs: fix
efi/efd error handling to avoid fs shutdown hangs"), the code has been
reworked such that error == -EFSCORRUPTED is not possible in this
codepath.

Remove the spurious error check and just use SHUTDOWN_META_IO_ERROR
unconditionally.
Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent a3916e52
...@@ -125,9 +125,7 @@ xfs_bmap_finish( ...@@ -125,9 +125,7 @@ xfs_bmap_finish(
if (committed) { if (committed) {
xfs_efi_release(efi); xfs_efi_release(efi);
xfs_force_shutdown((*tp)->t_mountp, xfs_force_shutdown((*tp)->t_mountp,
(error == -EFSCORRUPTED) ? SHUTDOWN_META_IO_ERROR);
SHUTDOWN_CORRUPT_INCORE :
SHUTDOWN_META_IO_ERROR);
} }
return error; return error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment