From 18b9f67962eb890da0c053e04c3cf0e91871d4fa Mon Sep 17 00:00:00 2001 From: NeilBrown <neilb@suse.com> Date: Fri, 14 Aug 2015 10:22:00 +1000 Subject: [PATCH] md-cluster: remove inappropriate try_module_get from join() md_setup_cluster already calls try_module_get(), so this try_module_get isn't needed. Also, there is no matching module_put (except in error patch), so this leaves an unbalanced module count. Signed-off-by: NeilBrown <neilb@suse.com> --- drivers/md/md-cluster.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c index c35a03a7eb11..11e3bc9d2a4b 100644 --- a/drivers/md/md-cluster.c +++ b/drivers/md/md-cluster.c @@ -687,9 +687,6 @@ static int join(struct mddev *mddev, int nodes) int ret, ops_rv; char str[64]; - if (!try_module_get(THIS_MODULE)) - return -ENOENT; - cinfo = kzalloc(sizeof(struct md_cluster_info), GFP_KERNEL); if (!cinfo) return -ENOMEM; @@ -771,7 +768,6 @@ static int join(struct mddev *mddev, int nodes) dlm_release_lockspace(cinfo->lockspace, 2); mddev->cluster_info = NULL; kfree(cinfo); - module_put(THIS_MODULE); return ret; } -- 2.30.9