Commit 2154c704 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller

r6040: fix all checkpatch errors and warnings

This patch fixes a couple of errors and warnings spotted by checkpatch.pl:
- some lines were over 80 columns
- there were some whitespaces left

The call to printk is now replaced by a call to pr_info and the log-level
included in the driver version is now removed, so there are no longer false
positives on this warning.
Signed-off-by: default avatarFlorian Fainelli <florian@openwrt.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7136e11e
...@@ -200,7 +200,7 @@ struct r6040_private { ...@@ -200,7 +200,7 @@ struct r6040_private {
int old_duplex; int old_duplex;
}; };
static char version[] __devinitdata = KERN_INFO DRV_NAME static char version[] __devinitdata = DRV_NAME
": RDC R6040 NAPI net driver," ": RDC R6040 NAPI net driver,"
"version "DRV_VERSION " (" DRV_RELDATE ")"; "version "DRV_VERSION " (" DRV_RELDATE ")";
...@@ -224,7 +224,8 @@ static int r6040_phy_read(void __iomem *ioaddr, int phy_addr, int reg) ...@@ -224,7 +224,8 @@ static int r6040_phy_read(void __iomem *ioaddr, int phy_addr, int reg)
} }
/* Write a word data from PHY Chip */ /* Write a word data from PHY Chip */
static void r6040_phy_write(void __iomem *ioaddr, int phy_addr, int reg, u16 val) static void r6040_phy_write(void __iomem *ioaddr,
int phy_addr, int reg, u16 val)
{ {
int limit = 2048; int limit = 2048;
u16 cmd; u16 cmd;
...@@ -348,8 +349,8 @@ static int r6040_alloc_rxbufs(struct net_device *dev) ...@@ -348,8 +349,8 @@ static int r6040_alloc_rxbufs(struct net_device *dev)
} }
desc->skb_ptr = skb; desc->skb_ptr = skb;
desc->buf = cpu_to_le32(pci_map_single(lp->pdev, desc->buf = cpu_to_le32(pci_map_single(lp->pdev,
desc->skb_ptr->data, desc->skb_ptr->data,
MAX_BUF_SIZE, PCI_DMA_FROMDEVICE)); MAX_BUF_SIZE, PCI_DMA_FROMDEVICE));
desc->status = DSC_OWNER_MAC; desc->status = DSC_OWNER_MAC;
desc = desc->vndescp; desc = desc->vndescp;
} while (desc != lp->rx_ring); } while (desc != lp->rx_ring);
...@@ -491,12 +492,14 @@ static int r6040_close(struct net_device *dev) ...@@ -491,12 +492,14 @@ static int r6040_close(struct net_device *dev)
/* Free Descriptor memory */ /* Free Descriptor memory */
if (lp->rx_ring) { if (lp->rx_ring) {
pci_free_consistent(pdev, RX_DESC_SIZE, lp->rx_ring, lp->rx_ring_dma); pci_free_consistent(pdev,
RX_DESC_SIZE, lp->rx_ring, lp->rx_ring_dma);
lp->rx_ring = NULL; lp->rx_ring = NULL;
} }
if (lp->tx_ring) { if (lp->tx_ring) {
pci_free_consistent(pdev, TX_DESC_SIZE, lp->tx_ring, lp->tx_ring_dma); pci_free_consistent(pdev,
TX_DESC_SIZE, lp->tx_ring, lp->tx_ring_dma);
lp->tx_ring = NULL; lp->tx_ring = NULL;
} }
...@@ -547,7 +550,7 @@ static int r6040_rx(struct net_device *dev, int limit) ...@@ -547,7 +550,7 @@ static int r6040_rx(struct net_device *dev, int limit)
} }
goto next_descr; goto next_descr;
} }
/* Packet successfully received */ /* Packet successfully received */
new_skb = netdev_alloc_skb(dev, MAX_BUF_SIZE); new_skb = netdev_alloc_skb(dev, MAX_BUF_SIZE);
if (!new_skb) { if (!new_skb) {
...@@ -556,13 +559,13 @@ static int r6040_rx(struct net_device *dev, int limit) ...@@ -556,13 +559,13 @@ static int r6040_rx(struct net_device *dev, int limit)
} }
skb_ptr = descptr->skb_ptr; skb_ptr = descptr->skb_ptr;
skb_ptr->dev = priv->dev; skb_ptr->dev = priv->dev;
/* Do not count the CRC */ /* Do not count the CRC */
skb_put(skb_ptr, descptr->len - 4); skb_put(skb_ptr, descptr->len - 4);
pci_unmap_single(priv->pdev, le32_to_cpu(descptr->buf), pci_unmap_single(priv->pdev, le32_to_cpu(descptr->buf),
MAX_BUF_SIZE, PCI_DMA_FROMDEVICE); MAX_BUF_SIZE, PCI_DMA_FROMDEVICE);
skb_ptr->protocol = eth_type_trans(skb_ptr, priv->dev); skb_ptr->protocol = eth_type_trans(skb_ptr, priv->dev);
/* Send to upper layer */ /* Send to upper layer */
netif_receive_skb(skb_ptr); netif_receive_skb(skb_ptr);
dev->stats.rx_packets++; dev->stats.rx_packets++;
...@@ -710,8 +713,10 @@ static int r6040_up(struct net_device *dev) ...@@ -710,8 +713,10 @@ static int r6040_up(struct net_device *dev)
return ret; return ret;
/* improve performance (by RDC guys) */ /* improve performance (by RDC guys) */
r6040_phy_write(ioaddr, 30, 17, (r6040_phy_read(ioaddr, 30, 17) | 0x4000)); r6040_phy_write(ioaddr, 30, 17,
r6040_phy_write(ioaddr, 30, 17, ~((~r6040_phy_read(ioaddr, 30, 17)) | 0x2000)); (r6040_phy_read(ioaddr, 30, 17) | 0x4000));
r6040_phy_write(ioaddr, 30, 17,
~((~r6040_phy_read(ioaddr, 30, 17)) | 0x2000));
r6040_phy_write(ioaddr, 0, 19, 0x0000); r6040_phy_write(ioaddr, 0, 19, 0x0000);
r6040_phy_write(ioaddr, 0, 30, 0x01F0); r6040_phy_write(ioaddr, 0, 30, 0x01F0);
...@@ -946,7 +951,7 @@ static const struct net_device_ops r6040_netdev_ops = { ...@@ -946,7 +951,7 @@ static const struct net_device_ops r6040_netdev_ops = {
.ndo_set_multicast_list = r6040_multicast_list, .ndo_set_multicast_list = r6040_multicast_list,
.ndo_change_mtu = eth_change_mtu, .ndo_change_mtu = eth_change_mtu,
.ndo_validate_addr = eth_validate_addr, .ndo_validate_addr = eth_validate_addr,
.ndo_set_mac_address = eth_mac_addr, .ndo_set_mac_address = eth_mac_addr,
.ndo_do_ioctl = r6040_ioctl, .ndo_do_ioctl = r6040_ioctl,
.ndo_tx_timeout = r6040_tx_timeout, .ndo_tx_timeout = r6040_tx_timeout,
#ifdef CONFIG_NET_POLL_CONTROLLER #ifdef CONFIG_NET_POLL_CONTROLLER
...@@ -1039,7 +1044,7 @@ static int __devinit r6040_init_one(struct pci_dev *pdev, ...@@ -1039,7 +1044,7 @@ static int __devinit r6040_init_one(struct pci_dev *pdev,
u16 *adrp; u16 *adrp;
int i; int i;
printk("%s\n", version); pr_info("%s\n", version);
err = pci_enable_device(pdev); err = pci_enable_device(pdev);
if (err) if (err)
...@@ -1113,7 +1118,8 @@ static int __devinit r6040_init_one(struct pci_dev *pdev, ...@@ -1113,7 +1118,8 @@ static int __devinit r6040_init_one(struct pci_dev *pdev,
/* Some bootloader/BIOSes do not initialize /* Some bootloader/BIOSes do not initialize
* MAC address, warn about that */ * MAC address, warn about that */
if (!(adrp[0] || adrp[1] || adrp[2])) { if (!(adrp[0] || adrp[1] || adrp[2])) {
netdev_warn(dev, "MAC address not initialized, generating random\n"); netdev_warn(dev, "MAC address not initialized, "
"generating random\n");
random_ether_addr(dev->dev_addr); random_ether_addr(dev->dev_addr);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment