Commit 3076066b authored by Alexander Shishkin's avatar Alexander Shishkin Committed by Greg Kroah-Hartman

intel_th: Don't leak module refcount on failure to activate

commit e609ccef upstream.

Output 'activation' may fail for the reasons of the output driver,
for example, if msc's buffer is not allocated. We forget, however,
to drop the module reference in this case. So each attempt at
activation in this case leaks a reference, preventing the module
from ever unloading.

This patch adds the missing module_put() in the activation error
path.
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b176a6ee
...@@ -218,8 +218,10 @@ static int intel_th_output_activate(struct intel_th_device *thdev) ...@@ -218,8 +218,10 @@ static int intel_th_output_activate(struct intel_th_device *thdev)
else else
intel_th_trace_enable(thdev); intel_th_trace_enable(thdev);
if (ret) if (ret) {
pm_runtime_put(&thdev->dev); pm_runtime_put(&thdev->dev);
module_put(thdrv->driver.owner);
}
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment