Commit 348eb0b2 authored by Andrea Merello's avatar Andrea Merello Committed by Jonathan Cameron

iio: ad7949: fix incorrect SPI xfer len

This driver supports 14-bits and 16-bits devices. All of them have a 14-bit
configuration registers. All SPI trasfers, for reading AD conversion
results and for writing the configuration register, fit in two bytes.

The driver always uses 4-bytes xfers which seems at least pointless (maybe
even harmful). This patch trims the SPI xfer len and the buffer size to
two bytes.
Signed-off-by: default avatarAndrea Merello <andrea.merello@gmail.com>
Reviewed-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 0fe2f2b7
...@@ -54,7 +54,7 @@ struct ad7949_adc_chip { ...@@ -54,7 +54,7 @@ struct ad7949_adc_chip {
u8 resolution; u8 resolution;
u16 cfg; u16 cfg;
unsigned int current_channel; unsigned int current_channel;
u32 buffer ____cacheline_aligned; u16 buffer ____cacheline_aligned;
}; };
static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val, static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,
...@@ -67,7 +67,7 @@ static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val, ...@@ -67,7 +67,7 @@ static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,
struct spi_transfer tx[] = { struct spi_transfer tx[] = {
{ {
.tx_buf = &ad7949_adc->buffer, .tx_buf = &ad7949_adc->buffer,
.len = 4, .len = 2,
.bits_per_word = bits_per_word, .bits_per_word = bits_per_word,
}, },
}; };
...@@ -95,7 +95,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val, ...@@ -95,7 +95,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val,
struct spi_transfer tx[] = { struct spi_transfer tx[] = {
{ {
.rx_buf = &ad7949_adc->buffer, .rx_buf = &ad7949_adc->buffer,
.len = 4, .len = 2,
.bits_per_word = bits_per_word, .bits_per_word = bits_per_word,
}, },
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment