Commit 3a84d6c9 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Takashi Iwai

ALSA: sound/isa: constify snd_kcontrol_new structures

Declare snd_kcontrol_new structures as const as they are only passed an
argument to the function snd_ctl_new1. This argument is of type const,
so snd_kcontrol_new structures having this property can be made const.
Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;
Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e0327a0f
...@@ -82,7 +82,7 @@ static int snd_gus_joystick_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el ...@@ -82,7 +82,7 @@ static int snd_gus_joystick_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el
return change; return change;
} }
static struct snd_kcontrol_new snd_gus_joystick_control = { static const struct snd_kcontrol_new snd_gus_joystick_control = {
.iface = SNDRV_CTL_ELEM_IFACE_CARD, .iface = SNDRV_CTL_ELEM_IFACE_CARD,
.name = "Joystick Speed", .name = "Joystick Speed",
.info = snd_gus_joystick_info, .info = snd_gus_joystick_info,
......
...@@ -809,7 +809,7 @@ static int snd_gf1_pcm_volume_put(struct snd_kcontrol *kcontrol, struct snd_ctl_ ...@@ -809,7 +809,7 @@ static int snd_gf1_pcm_volume_put(struct snd_kcontrol *kcontrol, struct snd_ctl_
return change; return change;
} }
static struct snd_kcontrol_new snd_gf1_pcm_volume_control = static const struct snd_kcontrol_new snd_gf1_pcm_volume_control =
{ {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "PCM Playback Volume", .name = "PCM Playback Volume",
...@@ -818,7 +818,7 @@ static struct snd_kcontrol_new snd_gf1_pcm_volume_control = ...@@ -818,7 +818,7 @@ static struct snd_kcontrol_new snd_gf1_pcm_volume_control =
.put = snd_gf1_pcm_volume_put .put = snd_gf1_pcm_volume_put
}; };
static struct snd_kcontrol_new snd_gf1_pcm_volume_control1 = static const struct snd_kcontrol_new snd_gf1_pcm_volume_control1 =
{ {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "GPCM Playback Volume", .name = "GPCM Playback Volume",
......
...@@ -1029,7 +1029,7 @@ static int snd_sb_qsound_space_put(struct snd_kcontrol *kcontrol, struct snd_ctl ...@@ -1029,7 +1029,7 @@ static int snd_sb_qsound_space_put(struct snd_kcontrol *kcontrol, struct snd_ctl
return change; return change;
} }
static struct snd_kcontrol_new snd_sb_qsound_switch = { static const struct snd_kcontrol_new snd_sb_qsound_switch = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "3D Control - Switch", .name = "3D Control - Switch",
.info = snd_sb_qsound_switch_info, .info = snd_sb_qsound_switch_info,
...@@ -1037,7 +1037,7 @@ static struct snd_kcontrol_new snd_sb_qsound_switch = { ...@@ -1037,7 +1037,7 @@ static struct snd_kcontrol_new snd_sb_qsound_switch = {
.put = snd_sb_qsound_switch_put .put = snd_sb_qsound_switch_put
}; };
static struct snd_kcontrol_new snd_sb_qsound_space = { static const struct snd_kcontrol_new snd_sb_qsound_space = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "3D Control - Space", .name = "3D Control - Space",
.info = snd_sb_qsound_space_info, .info = snd_sb_qsound_space_info,
......
...@@ -737,7 +737,7 @@ static int snd_sb16_dma_control_put(struct snd_kcontrol *kcontrol, struct snd_ct ...@@ -737,7 +737,7 @@ static int snd_sb16_dma_control_put(struct snd_kcontrol *kcontrol, struct snd_ct
return change; return change;
} }
static struct snd_kcontrol_new snd_sb16_dma_control = { static const struct snd_kcontrol_new snd_sb16_dma_control = {
.iface = SNDRV_CTL_ELEM_IFACE_CARD, .iface = SNDRV_CTL_ELEM_IFACE_CARD,
.name = "16-bit DMA Allocation", .name = "16-bit DMA Allocation",
.info = snd_sb16_dma_control_info, .info = snd_sb16_dma_control_info,
......
...@@ -671,7 +671,7 @@ static int sscape_midi_put(struct snd_kcontrol *kctl, ...@@ -671,7 +671,7 @@ static int sscape_midi_put(struct snd_kcontrol *kctl,
return change; return change;
} }
static struct snd_kcontrol_new midi_mixer_ctl = { static const struct snd_kcontrol_new midi_mixer_ctl = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "MIDI", .name = "MIDI",
.info = sscape_midi_info, .info = sscape_midi_info,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment