Commit 4b1debbe authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

ionic: fix memory leak of object 'lid'

Currently when netdev fails to allocate the error return path
fails to free the allocated object 'lid'.  Fix this by setting
err to the return error code and jumping to a new label that
performs the kfree of lid before returning.

Addresses-Coverity: ("Resource leak")
Fixes: 4b03b273 ("ionic: get MTU from lif identity")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarShannon Nelson <snelson@pensando.io>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent aff598ca
...@@ -2037,7 +2037,8 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index ...@@ -2037,7 +2037,8 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index
ionic->ntxqs_per_lif, ionic->ntxqs_per_lif); ionic->ntxqs_per_lif, ionic->ntxqs_per_lif);
if (!netdev) { if (!netdev) {
dev_err(dev, "Cannot allocate netdev, aborting\n"); dev_err(dev, "Cannot allocate netdev, aborting\n");
return ERR_PTR(-ENOMEM); err = -ENOMEM;
goto err_out_free_lid;
} }
SET_NETDEV_DEV(netdev, dev); SET_NETDEV_DEV(netdev, dev);
...@@ -2123,6 +2124,7 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index ...@@ -2123,6 +2124,7 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index
err_out_free_netdev: err_out_free_netdev:
free_netdev(lif->netdev); free_netdev(lif->netdev);
lif = NULL; lif = NULL;
err_out_free_lid:
kfree(lid); kfree(lid);
return ERR_PTR(err); return ERR_PTR(err);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment