Commit 4cd75ff0 authored by Anthony Koo's avatar Anthony Koo Committed by Alex Deucher

drm/amd/display: fix multi display seamless boot case

[Why]
There is a scenario that causes eDP to become blank if
there are multiple displays connected, and the external
display is set as the primary display such that the first
flip comes to the external display.

In this scenario, we call our optimize function before
the eDP even has a chance to flip.

[How]
There is a check that prevents bandwidth optimize from
occurring before first flip is complete on the seamless boot
display.
But actually it assumed the seamless boot display is the
first one to flip. But in this scenario it is not.
Modify the check to ensure the steam with the seamless
boot flag set is the one that has completed the first flip.
Signed-off-by: default avatarAnthony Koo <anthony.koo@amd.com>
Reviewed-by: default avatarAric Cyr <Aric.Cyr@amd.com>
Acked-by: default avatarBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 14ed3d00
...@@ -1138,9 +1138,6 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c ...@@ -1138,9 +1138,6 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c
const struct dc_link *link = context->streams[i]->link; const struct dc_link *link = context->streams[i]->link;
struct dc_stream_status *status; struct dc_stream_status *status;
if (context->streams[i]->apply_seamless_boot_optimization)
context->streams[i]->apply_seamless_boot_optimization = false;
if (!context->streams[i]->mode_changed) if (!context->streams[i]->mode_changed)
continue; continue;
...@@ -1792,10 +1789,15 @@ static void commit_planes_for_stream(struct dc *dc, ...@@ -1792,10 +1789,15 @@ static void commit_planes_for_stream(struct dc *dc,
if (dc->optimize_seamless_boot && surface_count > 0) { if (dc->optimize_seamless_boot && surface_count > 0) {
/* Optimize seamless boot flag keeps clocks and watermarks high until /* Optimize seamless boot flag keeps clocks and watermarks high until
* first flip. After first flip, optimization is required to lower * first flip. After first flip, optimization is required to lower
* bandwidth. * bandwidth. Important to note that it is expected UEFI will
* only light up a single display on POST, therefore we only expect
* one stream with seamless boot flag set.
*/ */
dc->optimize_seamless_boot = false; if (stream->apply_seamless_boot_optimization) {
dc->optimized_required = true; stream->apply_seamless_boot_optimization = false;
dc->optimize_seamless_boot = false;
dc->optimized_required = true;
}
} }
if (update_type == UPDATE_TYPE_FULL && !dc->optimize_seamless_boot) { if (update_type == UPDATE_TYPE_FULL && !dc->optimize_seamless_boot) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment