Commit 543c954d authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown

spi: atmel: fix return value check in atmel_spi_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 31407478
...@@ -1547,8 +1547,10 @@ static int atmel_spi_probe(struct platform_device *pdev) ...@@ -1547,8 +1547,10 @@ static int atmel_spi_probe(struct platform_device *pdev)
as->pdev = pdev; as->pdev = pdev;
as->regs = devm_ioremap_resource(&pdev->dev, regs); as->regs = devm_ioremap_resource(&pdev->dev, regs);
if (!as->regs) if (IS_ERR(as->regs)) {
ret = PTR_ERR(as->regs);
goto out_free_buffer; goto out_free_buffer;
}
as->phybase = regs->start; as->phybase = regs->start;
as->irq = irq; as->irq = irq;
as->clk = clk; as->clk = clk;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment