Commit 612cd9e8 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

[media] mt9m032.c: introduce missing initialization

The result of one call to a function is tested, and then at the second call
to the same function, the previous result, and not the current result, is
tested again.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
identifier f;
statement S1,S2;
@@

*ret = f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S1
... when any
*f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S2
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent b25b8958
...@@ -781,7 +781,7 @@ static int mt9m032_probe(struct i2c_client *client, ...@@ -781,7 +781,7 @@ static int mt9m032_probe(struct i2c_client *client,
ret = mt9m032_write(client, MT9M032_RESET, 1); /* reset on */ ret = mt9m032_write(client, MT9M032_RESET, 1); /* reset on */
if (ret < 0) if (ret < 0)
goto error_entity; goto error_entity;
mt9m032_write(client, MT9M032_RESET, 0); /* reset off */ ret = mt9m032_write(client, MT9M032_RESET, 0); /* reset off */
if (ret < 0) if (ret < 0)
goto error_entity; goto error_entity;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment