Commit 69678934 authored by Matej Groma's avatar Matej Groma Committed by Darren Hart

fujitsu-laptop: Rework brightness of eco led

For the sake of internal consistency, unset maximum brightness of eco
led and make it activatable only on values >= LED_FULL.
Signed-off-by: default avatarMatej Groma <matejgroma@gmail.com>
Acked-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 56a37a72
...@@ -212,7 +212,6 @@ static void eco_led_set(struct led_classdev *cdev, ...@@ -212,7 +212,6 @@ static void eco_led_set(struct led_classdev *cdev,
static struct led_classdev eco_led = { static struct led_classdev eco_led = {
.name = "fujitsu::eco_led", .name = "fujitsu::eco_led",
.max_brightness = 1,
.brightness_get = eco_led_get, .brightness_get = eco_led_get,
.brightness_set = eco_led_set .brightness_set = eco_led_set
}; };
...@@ -306,7 +305,7 @@ static void eco_led_set(struct led_classdev *cdev, ...@@ -306,7 +305,7 @@ static void eco_led_set(struct led_classdev *cdev,
int curr; int curr;
curr = call_fext_func(FUNC_LEDS, 0x2, ECO_LED, 0x0); curr = call_fext_func(FUNC_LEDS, 0x2, ECO_LED, 0x0);
if (brightness) if (brightness >= LED_FULL)
call_fext_func(FUNC_LEDS, 0x1, ECO_LED, curr | ECO_LED_ON); call_fext_func(FUNC_LEDS, 0x1, ECO_LED, curr | ECO_LED_ON);
else else
call_fext_func(FUNC_LEDS, 0x1, ECO_LED, curr & ~ECO_LED_ON); call_fext_func(FUNC_LEDS, 0x1, ECO_LED, curr & ~ECO_LED_ON);
...@@ -352,7 +351,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev) ...@@ -352,7 +351,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev)
enum led_brightness brightness = LED_OFF; enum led_brightness brightness = LED_OFF;
if (call_fext_func(FUNC_LEDS, 0x2, ECO_LED, 0x0) & ECO_LED_ON) if (call_fext_func(FUNC_LEDS, 0x2, ECO_LED, 0x0) & ECO_LED_ON)
brightness = cdev->max_brightness; brightness = LED_FULL;
return brightness; return brightness;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment