Commit 74052173 authored by Julia Lawall's avatar Julia Lawall Committed by Benjamin Herrenschmidt

powerpc/pseries: Use kstrdup

Use kstrdup when the goal of an allocation is copy a string into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@

-  to = kmalloc(strlen(from) + 1,flag);
+  to = kstrdup(from, flag);
   ... when != \(from = E1 \| to = E1 \)
   if (to==NULL || ...) S
   ... when != \(from = E2 \| to = E2 \)
-  strcpy(to, from);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 307a54cc
...@@ -118,12 +118,10 @@ static int pSeries_reconfig_add_node(const char *path, struct property *proplist ...@@ -118,12 +118,10 @@ static int pSeries_reconfig_add_node(const char *path, struct property *proplist
if (!np) if (!np)
goto out_err; goto out_err;
np->full_name = kmalloc(strlen(path) + 1, GFP_KERNEL); np->full_name = kstrdup(path, GFP_KERNEL);
if (!np->full_name) if (!np->full_name)
goto out_err; goto out_err;
strcpy(np->full_name, path);
np->properties = proplist; np->properties = proplist;
of_node_set_flag(np, OF_DYNAMIC); of_node_set_flag(np, OF_DYNAMIC);
kref_init(&np->kref); kref_init(&np->kref);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment