Commit 89e89b05 authored by Andrew Murray's avatar Andrew Murray Committed by Greg Kroah-Hartman

coresight: etm4x: improve clarity of etm4_os_unlock comment

To improve clarity, let's update the comment for etm4_os_unlock
to use the name of the register as per the ETM architecture
specification.

The existing comment is also misleading as it suggests any value
written to TRCOSLAR unlocks the trace registers, however it must
be '0' - let's also correct this.
Signed-off-by: default avatarAndrew Murray <andrew.murray@arm.com>
Reviewed-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20190829202842.580-13-mathieu.poirier@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 08d2ddaa
...@@ -48,7 +48,7 @@ static enum cpuhp_state hp_online; ...@@ -48,7 +48,7 @@ static enum cpuhp_state hp_online;
static void etm4_os_unlock(struct etmv4_drvdata *drvdata) static void etm4_os_unlock(struct etmv4_drvdata *drvdata)
{ {
/* Writing any value to ETMOSLAR unlocks the trace registers */ /* Writing 0 to TRCOSLAR unlocks the trace registers */
writel_relaxed(0x0, drvdata->base + TRCOSLAR); writel_relaxed(0x0, drvdata->base + TRCOSLAR);
drvdata->os_unlock = true; drvdata->os_unlock = true;
isb(); isb();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment