Commit 8ad3ba93 authored by Pan Bian's avatar Pan Bian Committed by David S. Miller

net: irda: set error code on failures

When the calls to kzalloc() fail, the value of return variable ret may
be 0. 0 means success in this context. This patch fixes the bug,
assigning "-ENOMEM" to ret before calling kzalloc().

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188971Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c79e167c
...@@ -1723,6 +1723,7 @@ static int irda_usb_probe(struct usb_interface *intf, ...@@ -1723,6 +1723,7 @@ static int irda_usb_probe(struct usb_interface *intf,
/* Don't change this buffer size and allocation without doing /* Don't change this buffer size and allocation without doing
* some heavy and complete testing. Don't ask why :-( * some heavy and complete testing. Don't ask why :-(
* Jean II */ * Jean II */
ret = -ENOMEM;
self->speed_buff = kzalloc(IRDA_USB_SPEED_MTU, GFP_KERNEL); self->speed_buff = kzalloc(IRDA_USB_SPEED_MTU, GFP_KERNEL);
if (!self->speed_buff) if (!self->speed_buff)
goto err_out_3; goto err_out_3;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment