Skip to content

L
linux
Commit 8ccf7b25 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files
Options

sparc32: uaccess_32 macro whitespace fixes 

Macros within arch/sparc/include/asm/uaccess_32.h are made harder to
read because they violate a bunch of coding style rules.

Fix it up.
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 99408c84
Hide whitespace changes
Inline Side-by-side
Showing with 227 additions and 138 deletions
arch/sparc/include/asm/uaccess_32.h
View file @ 8ccf7b25
...@@ -37,7 +37,7 @@ ...@@ -37,7 +37,7 @@
#define get_fs() (current->thread.current_ds) #define get_fs() (current->thread.current_ds)
#define set_fs(val) ((current->thread.current_ds) = (val)) #define set_fs(val) ((current->thread.current_ds) = (val))
#define segment_eq(a,b) ((a).seg == (b).seg) #define segment_eq(a, b) ((a).seg == (b).seg)
/* We have there a nice not-mapped page at PAGE_OFFSET - PAGE_SIZE, so that this test /* We have there a nice not-mapped page at PAGE_OFFSET - PAGE_SIZE, so that this test
* can be fairly lightweight. * can be fairly lightweight.
...@@ -46,8 +46,8 @@ ...@@ -46,8 +46,8 @@
*/ */
#define __user_ok(addr, size) ({ (void)(size); (addr) < STACK_TOP; }) #define __user_ok(addr, size) ({ (void)(size); (addr) < STACK_TOP; })
#define __kernel_ok (segment_eq(get_fs(), KERNEL_DS)) #define __kernel_ok (segment_eq(get_fs(), KERNEL_DS))
#define __access_ok(addr,size) (__user_ok((addr) & get_fs().seg,(size))) #define __access_ok(addr, size) (__user_ok((addr) & get_fs().seg, (size)))
#define access_ok(type, addr, size) \ #define access_ok(type, addr, size) \
({ (void)(type); __access_ok((unsigned long)(addr), size); }) ({ (void)(type); __access_ok((unsigned long)(addr), size); })
/* /*
...@@ -91,158 +91,247 @@ void __ret_efault(void); ...@@ -91,158 +91,247 @@ void __ret_efault(void);
* of a performance impact. Thus we have a few rather ugly macros here, * of a performance impact. Thus we have a few rather ugly macros here,
* and hide all the ugliness from the user. * and hide all the ugliness from the user.
*/ */
#define put_user(x,ptr) ({ \ #define put_user(x, ptr) ({ \
unsigned long __pu_addr = (unsigned long)(ptr); \ unsigned long __pu_addr = (unsigned long)(ptr); \
__chk_user_ptr(ptr); \ __chk_user_ptr(ptr); \
__put_user_check((__typeof__(*(ptr)))(x),__pu_addr,sizeof(*(ptr))); }) __put_user_check((__typeof__(*(ptr)))(x), __pu_addr, sizeof(*(ptr))); \
})
#define get_user(x,ptr) ({ \
unsigned long __gu_addr = (unsigned long)(ptr); \ #define get_user(x, ptr) ({ \
__chk_user_ptr(ptr); \ unsigned long __gu_addr = (unsigned long)(ptr); \
__get_user_check((x),__gu_addr,sizeof(*(ptr)),__typeof__(*(ptr))); }) __chk_user_ptr(ptr); \
__get_user_check((x), __gu_addr, sizeof(*(ptr)), __typeof__(*(ptr))); \
})
/* /*
* The "__xxx" versions do not do address space checking, useful when * The "__xxx" versions do not do address space checking, useful when
* doing multiple accesses to the same area (the user has to do the * doing multiple accesses to the same area (the user has to do the
* checks by hand with "access_ok()") * checks by hand with "access_ok()")
*/ */
#define __put_user(x,ptr) __put_user_nocheck((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr))) #define __put_user(x, ptr) \
#define __get_user(x,ptr) __get_user_nocheck((x),(ptr),sizeof(*(ptr)),__typeof__(*(ptr))) __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
#define __get_user(x, ptr) \
__get_user_nocheck((x), (ptr), sizeof(*(ptr)), __typeof__(*(ptr)))
struct __large_struct { unsigned long buf[100]; }; struct __large_struct { unsigned long buf[100]; };
#define __m(x) ((struct __large_struct __user *)(x)) #define __m(x) ((struct __large_struct __user *)(x))
#define __put_user_check(x,addr,size) ({ \ #define __put_user_check(x, addr, size) ({ \
register int __pu_ret; \ register int __pu_ret; \
if (__access_ok(addr,size)) { \ if (__access_ok(addr, size)) { \
switch (size) { \ switch (size) { \
case 1: __put_user_asm(x,b,addr,__pu_ret); break; \ case 1: \
case 2: __put_user_asm(x,h,addr,__pu_ret); break; \ __put_user_asm(x, b, addr, __pu_ret); \
case 4: __put_user_asm(x,,addr,__pu_ret); break; \ break; \
case 8: __put_user_asm(x,d,addr,__pu_ret); break; \ case 2: \
default: __pu_ret = __put_user_bad(); break; \ __put_user_asm(x, h, addr, __pu_ret); \
} } else { __pu_ret = -EFAULT; } __pu_ret; }) break; \
case 4: \
#define __put_user_nocheck(x,addr,size) ({ \ __put_user_asm(x, , addr, __pu_ret); \
register int __pu_ret; \ break; \
switch (size) { \ case 8: \
case 1: __put_user_asm(x,b,addr,__pu_ret); break; \ __put_user_asm(x, d, addr, __pu_ret); \
case 2: __put_user_asm(x,h,addr,__pu_ret); break; \ break; \
case 4: __put_user_asm(x,,addr,__pu_ret); break; \ default: \
case 8: __put_user_asm(x,d,addr,__pu_ret); break; \ __pu_ret = __put_user_bad(); \
default: __pu_ret = __put_user_bad(); break; \ break; \
} __pu_ret; }) } \
} else { \
#define __put_user_asm(x,size,addr,ret) \ __pu_ret = -EFAULT; \
} \
__pu_ret; \
})
#define __put_user_nocheck(x, addr, size) ({ \
register int __pu_ret; \
switch (size) { \
case 1: \
__put_user_asm(x, b, addr, __pu_ret); \
break; \
case 2: \
__put_user_asm(x, h, addr, __pu_ret); \
break; \
case 4: \
__put_user_asm(x, , addr, __pu_ret); \
break; \
case 8: \
__put_user_asm(x, d, addr, __pu_ret); \
break; \
default: \
__pu_ret = __put_user_bad(); \
break; \
} \
__pu_ret; \
})
#define __put_user_asm(x, size, addr, ret) \
__asm__ __volatile__( \ __asm__ __volatile__( \
"/* Put user asm, inline. */\n" \ "/* Put user asm, inline. */\n" \
"1:\t" "st"#size " %1, %2\n\t" \ "1:\t" "st"#size " %1, %2\n\t" \
"clr %0\n" \ "clr %0\n" \
"2:\n\n\t" \ "2:\n\n\t" \
".section .fixup,#alloc,#execinstr\n\t" \ ".section .fixup,#alloc,#execinstr\n\t" \
".align 4\n" \ ".align 4\n" \
"3:\n\t" \ "3:\n\t" \
"b 2b\n\t" \ "b 2b\n\t" \
" mov %3, %0\n\t" \ " mov %3, %0\n\t" \
".previous\n\n\t" \ ".previous\n\n\t" \
".section __ex_table,#alloc\n\t" \ ".section __ex_table,#alloc\n\t" \
".align 4\n\t" \ ".align 4\n\t" \
".word 1b, 3b\n\t" \ ".word 1b, 3b\n\t" \
".previous\n\n\t" \ ".previous\n\n\t" \
: "=&r" (ret) : "r" (x), "m" (*__m(addr)), \ : "=&r" (ret) : "r" (x), "m" (*__m(addr)), \
"i" (-EFAULT)) "i" (-EFAULT))
int __put_user_bad(void); int __put_user_bad(void);
#define __get_user_check(x,addr,size,type) ({ \ #define __get_user_check(x, addr, size, type) ({ \
register int __gu_ret; \ register int __gu_ret; \
register unsigned long __gu_val; \ register unsigned long __gu_val; \
if (__access_ok(addr,size)) { \ if (__access_ok(addr, size)) { \
switch (size) { \ switch (size) { \
case 1: __get_user_asm(__gu_val,ub,addr,__gu_ret); break; \ case 1: \
case 2: __get_user_asm(__gu_val,uh,addr,__gu_ret); break; \ __get_user_asm(__gu_val, ub, addr, __gu_ret); \
case 4: __get_user_asm(__gu_val,,addr,__gu_ret); break; \ break; \
case 8: __get_user_asm(__gu_val,d,addr,__gu_ret); break; \ case 2: \
default: __gu_val = 0; __gu_ret = __get_user_bad(); break; \ __get_user_asm(__gu_val, uh, addr, __gu_ret); \
} } else { __gu_val = 0; __gu_ret = -EFAULT; } x = (__force type) __gu_val; __gu_ret; }) break; \
case 4: \
#define __get_user_check_ret(x,addr,size,type,retval) ({ \ __get_user_asm(__gu_val, , addr, __gu_ret); \
register unsigned long __gu_val __asm__ ("l1"); \ break; \
if (__access_ok(addr,size)) { \ case 8: \
switch (size) { \ __get_user_asm(__gu_val, d, addr, __gu_ret); \
case 1: __get_user_asm_ret(__gu_val,ub,addr,retval); break; \ break; \
case 2: __get_user_asm_ret(__gu_val,uh,addr,retval); break; \ default: \
case 4: __get_user_asm_ret(__gu_val,,addr,retval); break; \ __gu_val = 0; \
case 8: __get_user_asm_ret(__gu_val,d,addr,retval); break; \ __gu_ret = __get_user_bad(); \
default: if (__get_user_bad()) return retval; \ break; \
} x = (__force type) __gu_val; } else return retval; }) } \
} else { \
#define __get_user_nocheck(x,addr,size,type) ({ \ __gu_val = 0; \
register int __gu_ret; \ __gu_ret = -EFAULT; \
register unsigned long __gu_val; \ } \
switch (size) { \ x = (__force type) __gu_val; \
case 1: __get_user_asm(__gu_val,ub,addr,__gu_ret); break; \ __gu_ret; \
case 2: __get_user_asm(__gu_val,uh,addr,__gu_ret); break; \ })
case 4: __get_user_asm(__gu_val,,addr,__gu_ret); break; \
case 8: __get_user_asm(__gu_val,d,addr,__gu_ret); break; \ #define __get_user_check_ret(x, addr, size, type, retval) ({ \
default: __gu_val = 0; __gu_ret = __get_user_bad(); break; \ register unsigned long __gu_val __asm__ ("l1"); \
} x = (__force type) __gu_val; __gu_ret; }) if (__access_ok(addr, size)) { \
switch (size) { \
#define __get_user_nocheck_ret(x,addr,size,type,retval) ({ \ case 1: \
register unsigned long __gu_val __asm__ ("l1"); \ __get_user_asm_ret(__gu_val, ub, addr, retval); \
switch (size) { \ break; \
case 1: __get_user_asm_ret(__gu_val,ub,addr,retval); break; \ case 2: \
case 2: __get_user_asm_ret(__gu_val,uh,addr,retval); break; \ __get_user_asm_ret(__gu_val, uh, addr, retval); \
case 4: __get_user_asm_ret(__gu_val,,addr,retval); break; \ break; \
case 8: __get_user_asm_ret(__gu_val,d,addr,retval); break; \ case 4: \
default: if (__get_user_bad()) return retval; \ __get_user_asm_ret(__gu_val, , addr, retval); \
} x = (__force type) __gu_val; }) break; \
case 8: \
#define __get_user_asm(x,size,addr,ret) \ __get_user_asm_ret(__gu_val, d, addr, retval); \
break; \
default: \
if (__get_user_bad()) \
return retval; \
} \
x = (__force type) __gu_val; \
} else \
return retval; \
})
#define __get_user_nocheck(x, addr, size, type) ({ \
register int __gu_ret; \
register unsigned long __gu_val; \
switch (size) { \
case 1: \
__get_user_asm(__gu_val, ub, addr, __gu_ret); \
break; \
case 2: \
__get_user_asm(__gu_val, uh, addr, __gu_ret); \
break; \
case 4: \
__get_user_asm(__gu_val, , addr, __gu_ret); \
break; \
case 8: \
__get_user_asm(__gu_val, d, addr, __gu_ret); \
break; \
default: \
__gu_val = 0; \
__gu_ret = __get_user_bad(); \
break; \
} \
x = (__force type) __gu_val; \
__gu_ret; \
})
#define __get_user_nocheck_ret(x, addr, size, type, retval) ({ \
register unsigned long __gu_val __asm__ ("l1"); \
switch (size) { \
case 1: \
__get_user_asm_ret(__gu_val, ub, addr, retval); \
break; \
case 2: \
__get_user_asm_ret(__gu_val, uh, addr, retval); \
break; \
case 4: \
__get_user_asm_ret(__gu_val, , addr, retval); \
break; \
case 8: \
__get_user_asm_ret(__gu_val, d, addr, retval); \
break; \
default: \
if (__get_user_bad()) \
return retval; \
} \
x = (__force type) __gu_val; \
})
#define __get_user_asm(x, size, addr, ret) \
__asm__ __volatile__( \ __asm__ __volatile__( \
"/* Get user asm, inline. */\n" \ "/* Get user asm, inline. */\n" \
"1:\t" "ld"#size " %2, %1\n\t" \ "1:\t" "ld"#size " %2, %1\n\t" \
"clr %0\n" \ "clr %0\n" \
"2:\n\n\t" \ "2:\n\n\t" \
".section .fixup,#alloc,#execinstr\n\t" \ ".section .fixup,#alloc,#execinstr\n\t" \
".align 4\n" \ ".align 4\n" \
"3:\n\t" \ "3:\n\t" \
"clr %1\n\t" \ "clr %1\n\t" \
"b 2b\n\t" \ "b 2b\n\t" \
" mov %3, %0\n\n\t" \ " mov %3, %0\n\n\t" \
".previous\n\t" \ ".previous\n\t" \
".section __ex_table,#alloc\n\t" \ ".section __ex_table,#alloc\n\t" \
".align 4\n\t" \ ".align 4\n\t" \
".word 1b, 3b\n\n\t" \ ".word 1b, 3b\n\n\t" \
".previous\n\t" \ ".previous\n\t" \
: "=&r" (ret), "=&r" (x) : "m" (*__m(addr)), \ : "=&r" (ret), "=&r" (x) : "m" (*__m(addr)), \
"i" (-EFAULT)) "i" (-EFAULT))
#define __get_user_asm_ret(x,size,addr,retval) \ #define __get_user_asm_ret(x, size, addr, retval) \
if (__builtin_constant_p(retval) && retval == -EFAULT) \ if (__builtin_constant_p(retval) && retval == -EFAULT) \
__asm__ __volatile__( \ __asm__ __volatile__( \
"/* Get user asm ret, inline. */\n" \ "/* Get user asm ret, inline. */\n" \
"1:\t" "ld"#size " %1, %0\n\n\t" \ "1:\t" "ld"#size " %1, %0\n\n\t" \
".section __ex_table,#alloc\n\t" \ ".section __ex_table,#alloc\n\t" \
".align 4\n\t" \ ".align 4\n\t" \
".word 1b,__ret_efault\n\n\t" \ ".word 1b,__ret_efault\n\n\t" \
".previous\n\t" \ ".previous\n\t" \
: "=&r" (x) : "m" (*__m(addr))); \ : "=&r" (x) : "m" (*__m(addr))); \
else \ else \
__asm__ __volatile__( \ __asm__ __volatile__( \
"/* Get user asm ret, inline. */\n" \ "/* Get user asm ret, inline. */\n" \
"1:\t" "ld"#size " %1, %0\n\n\t" \ "1:\t" "ld"#size " %1, %0\n\n\t" \
".section .fixup,#alloc,#execinstr\n\t" \ ".section .fixup,#alloc,#execinstr\n\t" \
".align 4\n" \ ".align 4\n" \
"3:\n\t" \ "3:\n\t" \
"ret\n\t" \ "ret\n\t" \
" restore %%g0, %2, %%o0\n\n\t" \ " restore %%g0, %2, %%o0\n\n\t" \
".previous\n\t" \ ".previous\n\t" \
".section __ex_table,#alloc\n\t" \ ".section __ex_table,#alloc\n\t" \
".align 4\n\t" \ ".align 4\n\t" \
".word 1b, 3b\n\n\t" \ ".word 1b, 3b\n\n\t" \
".previous\n\t" \ ".previous\n\t" \
: "=&r" (x) : "m" (*__m(addr)), "i" (retval)) : "=&r" (x) : "m" (*__m(addr)), "i" (retval))
int __get_user_bad(void); int __get_user_bad(void);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7