Commit 95ed3236 authored by Roger Quadros's avatar Roger Quadros Committed by Greg Kroah-Hartman

usb: gadget: f_mass_storage: Make us pass USBCV MSC Compliance tests

Defer the SET_CONFIG and SET_INTERFACE control transfer's data/status
stages till we are ready to process new CBW from the host. This way we
ensure that we don't loose any CBW during MSC compliance tests and cause
lock up.
Signed-off-by: default avatarRoger Quadros <roger.quadros@nokia.com>
Acked-by: default avatarMichal Nazarewicz <mina86@mina86.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1b9ba000
...@@ -347,6 +347,7 @@ struct fsg_operations { ...@@ -347,6 +347,7 @@ struct fsg_operations {
/* Data shared by all the FSG instances. */ /* Data shared by all the FSG instances. */
struct fsg_common { struct fsg_common {
struct usb_gadget *gadget; struct usb_gadget *gadget;
struct usb_composite_dev *cdev;
struct fsg_dev *fsg, *new_fsg; struct fsg_dev *fsg, *new_fsg;
wait_queue_head_t fsg_wait; wait_queue_head_t fsg_wait;
...@@ -2441,7 +2442,7 @@ static int fsg_set_alt(struct usb_function *f, unsigned intf, unsigned alt) ...@@ -2441,7 +2442,7 @@ static int fsg_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
struct fsg_dev *fsg = fsg_from_func(f); struct fsg_dev *fsg = fsg_from_func(f);
fsg->common->new_fsg = fsg; fsg->common->new_fsg = fsg;
raise_exception(fsg->common, FSG_STATE_CONFIG_CHANGE); raise_exception(fsg->common, FSG_STATE_CONFIG_CHANGE);
return 0; return USB_GADGET_DELAYED_STATUS;
} }
static void fsg_disable(struct usb_function *f) static void fsg_disable(struct usb_function *f)
...@@ -2577,6 +2578,8 @@ static void handle_exception(struct fsg_common *common) ...@@ -2577,6 +2578,8 @@ static void handle_exception(struct fsg_common *common)
case FSG_STATE_CONFIG_CHANGE: case FSG_STATE_CONFIG_CHANGE:
do_set_interface(common, common->new_fsg); do_set_interface(common, common->new_fsg);
if (common->new_fsg)
usb_composite_setup_continue(common->cdev);
break; break;
case FSG_STATE_EXIT: case FSG_STATE_EXIT:
...@@ -2747,6 +2750,7 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common, ...@@ -2747,6 +2750,7 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common,
common->gadget = gadget; common->gadget = gadget;
common->ep0 = gadget->ep0; common->ep0 = gadget->ep0;
common->ep0req = cdev->req; common->ep0req = cdev->req;
common->cdev = cdev;
/* Maybe allocate device-global string IDs, and patch descriptors */ /* Maybe allocate device-global string IDs, and patch descriptors */
if (fsg_strings[FSG_STRING_INTERFACE].id == 0) { if (fsg_strings[FSG_STRING_INTERFACE].id == 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment