Commit 9e9cdc89 authored by Kim, Milo's avatar Kim, Milo Committed by Linus Torvalds

backlight: lp855x_bl: simplify bl_get_brightness()

Getting the brightness value is not critical, no need to read the actual
register value.  To simplify it, just return the 'bl->props.brightness'
value.  Then, lp855x_read_byte() can be removed, not used any more.
Signed-off-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 26e8ccc2
...@@ -66,20 +66,6 @@ struct lp855x { ...@@ -66,20 +66,6 @@ struct lp855x {
struct pwm_device *pwm; struct pwm_device *pwm;
}; };
static int lp855x_read_byte(struct lp855x *lp, u8 reg, u8 *data)
{
int ret;
ret = i2c_smbus_read_byte_data(lp->client, reg);
if (ret < 0) {
dev_err(lp->dev, "failed to read 0x%.2x\n", reg);
return ret;
}
*data = (u8)ret;
return 0;
}
static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data) static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data)
{ {
return i2c_smbus_write_byte_data(lp->client, reg, data); return i2c_smbus_write_byte_data(lp->client, reg, data);
...@@ -274,16 +260,6 @@ static int lp855x_bl_update_status(struct backlight_device *bl) ...@@ -274,16 +260,6 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
static int lp855x_bl_get_brightness(struct backlight_device *bl) static int lp855x_bl_get_brightness(struct backlight_device *bl)
{ {
struct lp855x *lp = bl_get_data(bl);
enum lp855x_brightness_ctrl_mode mode = lp->pdata->mode;
if (mode == REGISTER_BASED) {
u8 val = 0;
lp855x_read_byte(lp, lp->cfg->reg_brightness, &val);
bl->props.brightness = val;
}
return bl->props.brightness; return bl->props.brightness;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment