Commit 9fd1a1c9 authored by afzal mohammed's avatar afzal mohammed Committed by Michal Simek

microblaze: Replace setup_irq() by request_irq()

request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanosSigned-off-by: default avatarafzal mohammed <afzal.mohd.ma@gmail.com>
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
parent 1babf557
...@@ -161,13 +161,6 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id) ...@@ -161,13 +161,6 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
static struct irqaction timer_irqaction = {
.handler = timer_interrupt,
.flags = IRQF_TIMER,
.name = "timer",
.dev_id = &clockevent_xilinx_timer,
};
static __init int xilinx_clockevent_init(void) static __init int xilinx_clockevent_init(void)
{ {
clockevent_xilinx_timer.mult = clockevent_xilinx_timer.mult =
...@@ -309,7 +302,8 @@ static int __init xilinx_timer_init(struct device_node *timer) ...@@ -309,7 +302,8 @@ static int __init xilinx_timer_init(struct device_node *timer)
freq_div_hz = timer_clock_freq / HZ; freq_div_hz = timer_clock_freq / HZ;
ret = setup_irq(irq, &timer_irqaction); ret = request_irq(irq, timer_interrupt, IRQF_TIMER, "timer",
&clockevent_xilinx_timer);
if (ret) { if (ret) {
pr_err("Failed to setup IRQ"); pr_err("Failed to setup IRQ");
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment