Commit a5cb5fa6 authored by Lyude Paul's avatar Lyude Paul

drm/dp_mst: Reformat drm_dp_check_act_status() a bit

Just add a bit more line wrapping, get rid of some extraneous
whitespace, remove an unneeded goto label, and move around some variable
declarations. No functional changes here.
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
[this isn't a fix, but it's needed for the fix that comes after this]
Fixes: ad7f8a1f ("drm/helper: add Displayport multi-stream helper (v0.6)")
Cc: Sean Paul <sean@poorly.run>
Cc: <stable@vger.kernel.org> # v3.17+
Reviewed-by: default avatarSean Paul <sean@poorly.run>
Link: https://patchwork.freedesktop.org/patch/msgid/20200406221253.1307209-3-lyude@redhat.com
parent 17e03aa8
...@@ -4451,33 +4451,31 @@ static int drm_dp_dpcd_write_payload(struct drm_dp_mst_topology_mgr *mgr, ...@@ -4451,33 +4451,31 @@ static int drm_dp_dpcd_write_payload(struct drm_dp_mst_topology_mgr *mgr,
*/ */
int drm_dp_check_act_status(struct drm_dp_mst_topology_mgr *mgr) int drm_dp_check_act_status(struct drm_dp_mst_topology_mgr *mgr)
{ {
int count = 0, ret;
u8 status; u8 status;
int ret;
int count = 0;
do { do {
ret = drm_dp_dpcd_readb(mgr->aux, DP_PAYLOAD_TABLE_UPDATE_STATUS, &status); ret = drm_dp_dpcd_readb(mgr->aux,
DP_PAYLOAD_TABLE_UPDATE_STATUS,
&status);
if (ret < 0) { if (ret < 0) {
DRM_DEBUG_KMS("failed to read payload table status %d\n", ret); DRM_DEBUG_KMS("failed to read payload table status %d\n",
goto fail; ret);
return ret;
} }
if (status & DP_PAYLOAD_ACT_HANDLED) if (status & DP_PAYLOAD_ACT_HANDLED)
break; break;
count++; count++;
udelay(100); udelay(100);
} while (count < 30); } while (count < 30);
if (!(status & DP_PAYLOAD_ACT_HANDLED)) { if (!(status & DP_PAYLOAD_ACT_HANDLED)) {
DRM_DEBUG_KMS("failed to get ACT bit %d after %d retries\n", status, count); DRM_DEBUG_KMS("failed to get ACT bit %d after %d retries\n",
ret = -EINVAL; status, count);
goto fail; return -EINVAL;
} }
return 0; return 0;
fail:
return ret;
} }
EXPORT_SYMBOL(drm_dp_check_act_status); EXPORT_SYMBOL(drm_dp_check_act_status);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment