Commit a5ea8a68 authored by Noralf Trønnes's avatar Noralf Trønnes

drm/gem-fb-helper: Use debug message on gem lookup failure

GEM lookup failure can easily be triggered by userspace so make
it a debug message, not an error message.

Also remove unnecessary inner parentheses and fix alphabetical
struct declaration order.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1505147865-18194-2-git-send-email-noralf@tronnes.org
parent bd106353
...@@ -154,7 +154,7 @@ drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file, ...@@ -154,7 +154,7 @@ drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file,
objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]); objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);
if (!objs[i]) { if (!objs[i]) {
DRM_DEV_ERROR(dev->dev, "Failed to lookup GEM\n"); DRM_DEBUG_KMS("Failed to lookup GEM object\n");
ret = -ENOENT; ret = -ENOENT;
goto err_gem_object_put; goto err_gem_object_put;
} }
...@@ -232,7 +232,7 @@ int drm_gem_fb_prepare_fb(struct drm_plane *plane, ...@@ -232,7 +232,7 @@ int drm_gem_fb_prepare_fb(struct drm_plane *plane,
struct dma_buf *dma_buf; struct dma_buf *dma_buf;
struct dma_fence *fence; struct dma_fence *fence;
if ((plane->state->fb == state->fb) || !state->fb) if (plane->state->fb == state->fb || !state->fb)
return 0; return 0;
dma_buf = drm_gem_fb_get_obj(state->fb, 0)->dma_buf; dma_buf = drm_gem_fb_get_obj(state->fb, 0)->dma_buf;
......
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
#define __DRM_GEM_FB_HELPER_H__ #define __DRM_GEM_FB_HELPER_H__
struct drm_device; struct drm_device;
struct drm_file;
struct drm_fb_helper_surface_size; struct drm_fb_helper_surface_size;
struct drm_file;
struct drm_framebuffer; struct drm_framebuffer;
struct drm_framebuffer_funcs; struct drm_framebuffer_funcs;
struct drm_gem_object; struct drm_gem_object;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment