Commit b7d485df authored by Evan Quan's avatar Evan Quan Committed by Alex Deucher

drm/amd/powerplay: fix the confusing ppfeature mask calculations

Simplify the ppfeature mask calculations.
Signed-off-by: default avatarEvan Quan <evan.quan@amd.com>
Reviewed-by: default avatarKenneth Feng <kenneth.feng@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6a7a20ed
...@@ -4407,9 +4407,9 @@ static int vega10_set_ppfeature_status(struct pp_hwmgr *hwmgr, uint64_t new_ppfe ...@@ -4407,9 +4407,9 @@ static int vega10_set_ppfeature_status(struct pp_hwmgr *hwmgr, uint64_t new_ppfe
return ret; return ret;
features_to_disable = features_to_disable =
(features_enabled ^ new_ppfeature_masks) & features_enabled; features_enabled & ~new_ppfeature_masks;
features_to_enable = features_to_enable =
(features_enabled ^ new_ppfeature_masks) ^ features_to_disable; ~features_enabled & new_ppfeature_masks;
pr_debug("features_to_disable 0x%llx\n", features_to_disable); pr_debug("features_to_disable 0x%llx\n", features_to_disable);
pr_debug("features_to_enable 0x%llx\n", features_to_enable); pr_debug("features_to_enable 0x%llx\n", features_to_enable);
......
...@@ -2009,9 +2009,9 @@ static int vega12_set_ppfeature_status(struct pp_hwmgr *hwmgr, uint64_t new_ppfe ...@@ -2009,9 +2009,9 @@ static int vega12_set_ppfeature_status(struct pp_hwmgr *hwmgr, uint64_t new_ppfe
return ret; return ret;
features_to_disable = features_to_disable =
(features_enabled ^ new_ppfeature_masks) & features_enabled; features_enabled & ~new_ppfeature_masks;
features_to_enable = features_to_enable =
(features_enabled ^ new_ppfeature_masks) ^ features_to_disable; ~features_enabled & new_ppfeature_masks;
pr_debug("features_to_disable 0x%llx\n", features_to_disable); pr_debug("features_to_disable 0x%llx\n", features_to_disable);
pr_debug("features_to_enable 0x%llx\n", features_to_enable); pr_debug("features_to_enable 0x%llx\n", features_to_enable);
......
...@@ -3084,9 +3084,9 @@ static int vega20_set_ppfeature_status(struct pp_hwmgr *hwmgr, uint64_t new_ppfe ...@@ -3084,9 +3084,9 @@ static int vega20_set_ppfeature_status(struct pp_hwmgr *hwmgr, uint64_t new_ppfe
return ret; return ret;
features_to_disable = features_to_disable =
(features_enabled ^ new_ppfeature_masks) & features_enabled; features_enabled & ~new_ppfeature_masks;
features_to_enable = features_to_enable =
(features_enabled ^ new_ppfeature_masks) ^ features_to_disable; ~features_enabled & new_ppfeature_masks;
pr_debug("features_to_disable 0x%llx\n", features_to_disable); pr_debug("features_to_disable 0x%llx\n", features_to_disable);
pr_debug("features_to_enable 0x%llx\n", features_to_enable); pr_debug("features_to_enable 0x%llx\n", features_to_enable);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment