From b9fada70f72ba7557c297736dc55701f510424bd Mon Sep 17 00:00:00 2001 From: Jeff Garzik <jgarzik@pobox.com> Date: Wed, 22 Dec 2004 08:58:50 -0500 Subject: [PATCH] [libata sata_nv] fix dev detect by removing sata-reset flag Remove ATA_FLAG_SATA_RESET. See comment in code and http://bugme.osdl.org/show_bug.cgi?id=3352 for more details. This problem needs more investigation. Removing the flag appears to fix the problems in the field, so it's the best temporary solution. --- drivers/scsi/sata_nv.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sata_nv.c b/drivers/scsi/sata_nv.c index 36b03d4b0d12..a21105cb712d 100644 --- a/drivers/scsi/sata_nv.c +++ b/drivers/scsi/sata_nv.c @@ -218,10 +218,18 @@ static struct ata_port_operations nv_ops = { .host_stop = nv_host_stop, }; +/* FIXME: The hardware provides the necessary SATA PHY controls + * to support ATA_FLAG_SATA_RESET. However, it is currently + * necessary to disable that flag, to solve misdetection problems. + * See http://bugme.osdl.org/show_bug.cgi?id=3352 for more info. + * + * This problem really needs to be investigated further. But in the + * meantime, we avoid ATA_FLAG_SATA_RESET to get people working. + */ static struct ata_port_info nv_port_info = { .sht = &nv_sht, .host_flags = ATA_FLAG_SATA | - ATA_FLAG_SATA_RESET | + /* ATA_FLAG_SATA_RESET | */ ATA_FLAG_SRST | ATA_FLAG_NO_LEGACY, .pio_mask = NV_PIO_MASK, -- 2.30.9