Commit bfc303e7 authored by Peter Griffin's avatar Peter Griffin Committed by Mauro Carvalho Chehab

[media] c8sectpfe: Remove clk_disable_unprepare hacks

Now that CLK_PROC_STFE is defined as a critical clock in
DT, we can remove the commented clk_disable_unprepare from
the c8sectpfe driver. This means we now have balanced
clk*enable/disable calls in the driver, but on STiH407
family the clock in reality will never actually be disabled.

This is due to a HW bug where once the IP has been configured
and the SLIM core is running, disabling the clock causes a
unrecoverable bus lockup.
Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Acked-by: default avatarPatrice Chotard <patrice.chotard@st.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 8be135d0
...@@ -885,8 +885,7 @@ static int c8sectpfe_probe(struct platform_device *pdev) ...@@ -885,8 +885,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
return 0; return 0;
err_clk_disable: err_clk_disable:
/* TODO uncomment when upstream has taken a reference on this clk */ clk_disable_unprepare(fei->c8sectpfeclk);
/*clk_disable_unprepare(fei->c8sectpfeclk);*/
return ret; return ret;
} }
...@@ -921,11 +920,8 @@ static int c8sectpfe_remove(struct platform_device *pdev) ...@@ -921,11 +920,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
if (readl(fei->io + SYS_OTHER_CLKEN)) if (readl(fei->io + SYS_OTHER_CLKEN))
writel(0, fei->io + SYS_OTHER_CLKEN); writel(0, fei->io + SYS_OTHER_CLKEN);
/* TODO uncomment when upstream has taken a reference on this clk */
/*
if (fei->c8sectpfeclk) if (fei->c8sectpfeclk)
clk_disable_unprepare(fei->c8sectpfeclk); clk_disable_unprepare(fei->c8sectpfeclk);
*/
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment