Commit f99844cb authored by Ingo Molnar's avatar Ingo Molnar

perf stat: Fix -nan% output in perf stat noise printouts

Before:

                 0 CPU-migrations           #    0.000 M/sec                    ( +-  -nan% )

After:

                 0 CPU-migrations           #    0.000 M/sec                    ( +-  0.00% )

Also factor out the noise printing function.
Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/n/tip-z89h2v1bk1mikcbsf7e6v34q@git.kernel.orgSigned-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 1fc570ad
...@@ -382,6 +382,16 @@ static int run_perf_stat(int argc __used, const char **argv) ...@@ -382,6 +382,16 @@ static int run_perf_stat(int argc __used, const char **argv)
return WEXITSTATUS(status); return WEXITSTATUS(status);
} }
static void print_noise_pct(double total, double avg)
{
double pct = 0.0;
if (avg)
pct = 100.0*total/avg;
fprintf(stderr, " ( +-%6.2f%% )", pct);
}
static void print_noise(struct perf_evsel *evsel, double avg) static void print_noise(struct perf_evsel *evsel, double avg)
{ {
struct perf_stat *ps; struct perf_stat *ps;
...@@ -390,8 +400,7 @@ static void print_noise(struct perf_evsel *evsel, double avg) ...@@ -390,8 +400,7 @@ static void print_noise(struct perf_evsel *evsel, double avg)
return; return;
ps = evsel->priv; ps = evsel->priv;
fprintf(stderr, " ( +- %7.3f%% )", print_noise_pct(stddev_stats(&ps->res_stats[0]), avg);
100 * stddev_stats(&ps->res_stats[0]) / avg);
} }
static void nsec_printout(int cpu, struct perf_evsel *evsel, double avg) static void nsec_printout(int cpu, struct perf_evsel *evsel, double avg)
...@@ -635,9 +644,8 @@ static void print_stat(int argc, const char **argv) ...@@ -635,9 +644,8 @@ static void print_stat(int argc, const char **argv)
fprintf(stderr, " %18.9f seconds time elapsed", fprintf(stderr, " %18.9f seconds time elapsed",
avg_stats(&walltime_nsecs_stats)/1e9); avg_stats(&walltime_nsecs_stats)/1e9);
if (run_count > 1) { if (run_count > 1) {
fprintf(stderr, " ( +-%5.2f%% )", print_noise_pct(stddev_stats(&walltime_nsecs_stats),
100*stddev_stats(&walltime_nsecs_stats) / avg_stats(&walltime_nsecs_stats));
avg_stats(&walltime_nsecs_stats));
} }
fprintf(stderr, "\n\n"); fprintf(stderr, "\n\n");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment